r94374 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94373‎ | r94374 | r94375 >
Date:19:24, 12 August 2011
Author:aaron
Status:ok
Tags:
Comment:
More to r94370:
* Fixed hard-coded output message (use $table)
* Removed doPopulateRevSha1 from SqliteUpdater.php too (didn't notice someone added this)
Modified paths:
  • /trunk/phase3/includes/installer/SqliteUpdater.php (modified) (history)
  • /trunk/phase3/maintenance/populateRevisionSha1.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/populateRevisionSha1.php
@@ -68,7 +68,7 @@
6969 $start = $db->selectField( $table, "MIN($idCol)", false, __METHOD__ );
7070 $end = $db->selectField( $table, "MAX($idCol)", false, __METHOD__ );
7171 if ( !$start || !$end ) {
72 - $this->output( "...revision table seems to be empty.\n" );
 72+ $this->output( "...$table table seems to be empty.\n" );
7373 return true;
7474 }
7575
Index: trunk/phase3/includes/installer/SqliteUpdater.php
@@ -64,8 +64,7 @@
6565 array( 'addTable', 'config', 'patch-config.sql' ),
6666 array( 'addIndex', 'logging', 'type_action', 'patch-logging-type-action-index.sql'),
6767 array( 'addField', 'revision', 'rev_sha1', 'patch-rev_sha1.sql' ),
68 - array( 'addField', 'archive', 'ar_sha1', 'patch-ar_sha1.sql' ),
69 - array( 'doPopulateRevSha1' ),
 68+ array( 'addField', 'archive', 'ar_sha1', 'patch-ar_sha1.sql' )
7069 );
7170 }
7271

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94370* Added LoggedUpdateMaintenance subclass...aaron19:11, 12 August 2011

Status & tagging log