r94365 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94364‎ | r94365 | r94366 >
Date:17:35, 12 August 2011
Author:preilly
Status:ok
Tags:
Comment:
fix for vertical alignment issue in r94303
Modified paths:
  • /trunk/extensions/MobileFrontend/MobileFrontend.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/MobileFrontend.php
@@ -49,7 +49,7 @@
5050 $wgHooks['SkinTemplateOutputPageBeforeExec'][] = array( &$wgExtMobileFrontend, 'addMobileFooter' );
5151
5252 class ExtMobileFrontend {
53 - const VERSION = '0.5.19';
 53+ const VERSION = '0.5.20';
5454
5555 /**
5656 * @var DOMDocument
@@ -225,7 +225,7 @@
226226 self::$format = $wgRequest->getText( 'format' );
227227 self::$requestedSegment = $wgRequest->getText( 'seg', 0 );
228228 self::$search = $wgRequest->getText( 'search' );
229 - self::$callback = $wgRequest->getText( 'callback' );
 229+ self::$callback = $wgRequest->getText( 'callback' );
230230
231231 $acceptHeader = $_SERVER["HTTP_ACCEPT"];
232232 $device = new DeviceDetection();
@@ -356,17 +356,17 @@
357357 $this->getMsg();
358358 $dir = self::$dir;
359359 $code = self::$code;
360 - $regularSite = self::$messages['mobile-frontend-regular-site'];
361 - $permStopRedirect = self::$messages['mobile-frontend-perm-stop-redirect'];
362 - $copyright = self::$messages['mobile-frontend-copyright'];
363 - $homeButton = self::$messages['mobile-frontend-home-button'];
364 - $randomButton = self::$messages['mobile-frontend-random-button'];
365 - $yesButton = self::$messages['mobile-frontend-opt-in-yes-button'];
366 - $noButton = self::$messages['mobile-frontend-opt-in-no-button'];
367 - $htmlTitle = self::$messages['mobile-frontend-opt-in-title'];
368 - $explainOptIn = self::$messages['mobile-frontend-opt-in-explain'];
369 - $disableImages = self::$messages['mobile-frontend-disable-images'];
370 - $optInMessage = self::$messages['mobile-frontend-opt-in-message'];
 360+ $regularSite = self::$messages['mobile-frontend-regular-site'];
 361+ $permStopRedirect = self::$messages['mobile-frontend-perm-stop-redirect'];
 362+ $copyright = self::$messages['mobile-frontend-copyright'];
 363+ $homeButton = self::$messages['mobile-frontend-home-button'];
 364+ $randomButton = self::$messages['mobile-frontend-random-button'];
 365+ $yesButton = self::$messages['mobile-frontend-opt-in-yes-button'];
 366+ $noButton = self::$messages['mobile-frontend-opt-in-no-button'];
 367+ $htmlTitle = self::$messages['mobile-frontend-opt-in-title'];
 368+ $explainOptIn = self::$messages['mobile-frontend-opt-in-explain'];
 369+ $disableImages = self::$messages['mobile-frontend-disable-images'];
 370+ $optInMessage = self::$messages['mobile-frontend-opt-in-message'];
371371 $cssFileName = ( isset( self::$device['css_file_name'] ) ) ? self::$device['css_file_name'] : 'default';
372372 require( 'views/layout/_search_webkit.html.php' );
373373 require( 'views/layout/_footmenu_default.html.php' );
@@ -383,17 +383,17 @@
384384 $this->getMsg();
385385 $dir = self::$dir;
386386 $code = self::$code;
387 - $regularSite = self::$messages['mobile-frontend-regular-site'];
388 - $permStopRedirect = self::$messages['mobile-frontend-perm-stop-redirect'];
389 - $copyright = self::$messages['mobile-frontend-copyright'];
390 - $homeButton = self::$messages['mobile-frontend-home-button'];
391 - $randomButton = self::$messages['mobile-frontend-random-button'];
392 - $yesButton = self::$messages['mobile-frontend-opt-out-yes-button'];
393 - $noButton = self::$messages['mobile-frontend-opt-out-no-button'];
394 - $htmlTitle = self::$messages['mobile-frontend-opt-out-title'];
395 - $explainOptOut = self::$messages['mobile-frontend-opt-out-explain'];
396 - $optOutMessage = self::$messages['mobile-frontend-opt-out-message'];
397 - $disableImages = self::$messages['mobile-frontend-disable-images'];
 387+ $regularSite = self::$messages['mobile-frontend-regular-site'];
 388+ $permStopRedirect = self::$messages['mobile-frontend-perm-stop-redirect'];
 389+ $copyright = self::$messages['mobile-frontend-copyright'];
 390+ $homeButton = self::$messages['mobile-frontend-home-button'];
 391+ $randomButton = self::$messages['mobile-frontend-random-button'];
 392+ $yesButton = self::$messages['mobile-frontend-opt-out-yes-button'];
 393+ $noButton = self::$messages['mobile-frontend-opt-out-no-button'];
 394+ $htmlTitle = self::$messages['mobile-frontend-opt-out-title'];
 395+ $explainOptOut = self::$messages['mobile-frontend-opt-out-explain'];
 396+ $optOutMessage = self::$messages['mobile-frontend-opt-out-message'];
 397+ $disableImages = self::$messages['mobile-frontend-disable-images'];
398398 $cssFileName = ( isset( self::$device['css_file_name'] ) ) ? self::$device['css_file_name'] : 'default';
399399 require( 'views/layout/_search_webkit.html.php' );
400400 require( 'views/layout/_footmenu_default.html.php' );
@@ -410,16 +410,16 @@
411411 $this->getMsg();
412412 $dir = self::$dir;
413413 $code = self::$code;
414 - $regularSite = self::$messages['mobile-frontend-regular-site'];
415 - $permStopRedirect = self::$messages['mobile-frontend-perm-stop-redirect'];
416 - $copyright = self::$messages['mobile-frontend-copyright'];
417 - $homeButton = self::$messages['mobile-frontend-home-button'];
418 - $randomButton = self::$messages['mobile-frontend-random-button'];
419 - $areYouSure = self::$messages['mobile-frontend-are-you-sure'];
420 - $explainDisable = self::$messages['mobile-frontend-explain-disable'];
421 - $disableButton = self::$messages['mobile-frontend-disable-button'];
422 - $backButton = self::$messages['mobile-frontend-back-button'];
423 - $disableImages = self::$messages['mobile-frontend-disable-images'];
 414+ $regularSite = self::$messages['mobile-frontend-regular-site'];
 415+ $permStopRedirect = self::$messages['mobile-frontend-perm-stop-redirect'];
 416+ $copyright = self::$messages['mobile-frontend-copyright'];
 417+ $homeButton = self::$messages['mobile-frontend-home-button'];
 418+ $randomButton = self::$messages['mobile-frontend-random-button'];
 419+ $areYouSure = self::$messages['mobile-frontend-are-you-sure'];
 420+ $explainDisable = self::$messages['mobile-frontend-explain-disable'];
 421+ $disableButton = self::$messages['mobile-frontend-disable-button'];
 422+ $backButton = self::$messages['mobile-frontend-back-button'];
 423+ $disableImages = self::$messages['mobile-frontend-disable-images'];
424424 $htmlTitle = $areYouSure;
425425 $title = $areYouSure;
426426 $cssFileName = ( isset( self::$device['css_file_name'] ) ) ? self::$device['css_file_name'] : 'default';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94303fix for Bug 29520 - Ability to turn off images on mobile and wap-mobile page ...preilly23:40, 11 August 2011

Status & tagging log