r94342 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94341‎ | r94342 | r94343 >
Date:12:41, 12 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
follow-up:r94340, r94116
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -66,7 +66,7 @@
6767 * Overridden from parent to ignore GUI parameters 'format' 'limit' and 'offset'
6868 */
6969 protected function showFormatOptions( $format, array $paramValues, array $ignoredAttribs = array() ) {
70 - return parent::showFormatOptions( $format, $paramValues, array( 'format', 'limit', 'offset', 'mainlabel' ) );
 70+ return parent::showFormatOptions( $format, $paramValues, array( 'format', 'limit', 'offset' ) );
7171 }
7272 /**
7373 * Creates the input form
@@ -131,7 +131,12 @@
132132 <script type="text/javascript">
133133 jQuery(document).ready(function(){
134134 jQuery('#embed-code-dialog').dialog({
135 - autoOpen:false
 135+ autoOpen:false,
 136+ buttons:{
 137+ Ok: function(){
 138+ jQuery(this).dialog("close");
 139+ }
 140+ }
136141 });
137142 jQuery('#show-embed-code').bind('click', function(){
138143 jQuery('#embed-code-dialog').dialog("open");

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94116added control for category optionsdevayon15:44, 9 August 2011
r94340modal window for embed codedevayon11:58, 12 August 2011