r94292 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94291‎ | r94292 | r94293 >
Date:22:27, 11 August 2011
Author:neilk
Status:deferred
Tags:
Comment:
make xsrf less likely
Modified paths:
  • /branches/extensions-realtime/IdentityApi/api/ApiQueryIdentity.php (modified) (history)

Diff [purge]

Index: branches/extensions-realtime/IdentityApi/api/ApiQueryIdentity.php
@@ -32,17 +32,12 @@
3333
3434 }
3535
36 - /**
37 - * ???? do we need this? XSRF? TODO
38 - * Indicates whether this module must be called with a POST request
39 - * @return bool
40 - */
4136 public function mustBePosted() {
42 - return false;
 37+ return true;
4338 }
4439
4540 /**
46 - * Probably needed to avoid XSRF -- TODO
 41+ * May be needed to avoid XSRF -- TODO determine if this is needed
4742 * Returns whether this module requires a Token to execute
4843 * @return bool
4944 */

Status & tagging log