r94240 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94239‎ | r94240 | r94241 >
Date:13:14, 11 August 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
fix bug reported by James Hong Kong
Modified paths:
  • /trunk/extensions/SemanticResultFormats/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php (modified) (history)
  • /trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotPie.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/RELEASE-NOTES
@@ -5,6 +5,7 @@
66 == SRF 1.6.1 ==
77
88 * Fixed rendering bug in the tagcloud format occuring for inline queries.
 9+* Fixed jqPlotBar and jqPlotPie rendering on Special:Ask and other special pages.
910
1011 == SRF 1.6 ==
1112
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotPie.php
@@ -6,10 +6,6 @@
77 * @author Yaron Koren
88 */
99
10 -if ( !defined( 'MEDIAWIKI' ) ) {
11 - die( 'Not an entry point.' );
12 -}
13 -
1410 class SRFjqPlotPie extends SMWResultPrinter {
1511 protected $m_width = 400;
1612 protected $m_height = 400;
@@ -105,9 +101,7 @@
106102 }
107103
108104 protected function getResultText( SMWQueryResult $res, $outputmode ) {
109 - global $wgOut, $wgParser;
110 -
111 - $wgParser->disableCache();
 105+ global $wgOut;
112106
113107 $this->addJavascriptAndCSS();
114108
Index: trunk/extensions/SemanticResultFormats/jqPlot/SRF_jqPlotBar.php
@@ -132,10 +132,8 @@
133133 }
134134
135135 protected function getResultText( SMWQueryResult $res, $outputmode ) {
136 - global $wgOut, $wgParser;
 136+ global $wgOut;
137137
138 - $wgParser->disableCache();
139 -
140138 self::addJavascriptAndCSS();
141139
142140 $this->isHTML = true;