r94232 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94231‎ | r94232 | r94233 >
Date:07:34, 11 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
style fix (css class names)
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -37,7 +37,7 @@
3838 $html_output = $this->makeResults( $p );
3939 if ( $this->uiCore->getQueryString() != "" ) {
4040 if ( $this->usesNavigationBar() ) {
41 - $html_output .= Html::rawElement( 'div', array( 'class' => 'smw-qc-navbar' ),
 41+ $html_output .= Html::rawElement( 'div', array( 'class' => 'smwqcnavbar' ),
4242 $this->getNavigationBar ( $this->uiCore->getLimit(), $this->uiCore->getOffset(), $this->uiCore->hasFurtherResults() )
4343 ); // ? can we preload offset and limit?
4444 }
@@ -45,7 +45,7 @@
4646 $html_output .= Html::rawElement( 'div', array( 'class' => 'smw-qc-result' ), $this->uiCore->getHTMLResult() );
4747
4848 if ( $this->usesNavigationBar() ) {
49 - $html_output .= Html::rawElement( 'div', array( 'class' => 'smw-qc-navbar' ),
 49+ $html_output .= Html::rawElement( 'div', array( 'class' => 'smwqcnavbar' ),
5050 $this->getNavigationBar ( $this->uiCore->getLimit(), $this->uiCore->getOffset(), $this->uiCore->hasFurtherResults() )
5151 ); // ? can we preload offset and limit?
5252 }
@@ -297,7 +297,7 @@
298298 foreach ( $additional_POs as $key => $value ) {
299299 if ( is_array( $property_values ) and array_key_exists( $key, $property_values ) ) {
300300 // make a element for additional properties
301 - $result .= Html::openElement( 'div', array( 'id' => "sort_div_$i", 'class' => 'smw-sort' ) );
 301+ $result .= Html::openElement( 'div', array( 'id' => "sort_div_$i", 'class' => 'smwsort' ) );
302302 $result .= '<span class="smw-remove"><a href="javascript:removePOInstance(\'sort_div_' . $i . '\')"><img src="' . $smwgScriptPath . '/skins/images/close-button.png" alt="' . wfMsg( 'smw_qui_delete' ) . '"></a></span>';
303303 $result .= wfMsg( 'smw_qui_property' );
304304 $result .= Html::input( 'property[' . $i . ']', $property_values[$key], 'text', array( 'size' => '35', 'id' => "property$i" ) ) . "\n";
@@ -322,7 +322,7 @@
323323 $i++;
324324 }
325325 if ( is_array( $category_values ) and array_key_exists( $key, $category_values ) ) {
326 - $result .= Html::openElement( 'div', array( 'id' => "sort_div_$i", 'class' => 'smw-sort' ) );
 326+ $result .= Html::openElement( 'div', array( 'id' => "sort_div_$i", 'class' => 'smwsort' ) );
327327 $result .= '<span class="smw-remove"><a href="javascript:removePOInstance(\'sort_div_' . $i . '\')"><img src="' . $smwgScriptPath . '/skins/images/close-button.png" alt="' . wfMsg( 'smw_qui_delete' ) . '"></a></span>' .
328328 'Category (optional)' . // todo: i18n
329329 Xml::input( "category[$i]", '20', $category_values[$key], array( 'id' => "category$i" ) ) . " " .
@@ -337,7 +337,7 @@
338338 // END: create form elements already submitted earlier via form
339339
340340 // create hidden form elements to be cloned later
341 - $hidden_property = Html::openElement( 'div', array( 'id' => 'property_starter', 'class' => 'smw-sort', 'style' => 'display:none' ) ) .
 341+ $hidden_property = Html::openElement( 'div', array( 'id' => 'property_starter', 'class' => 'smwsort', 'style' => 'display:none' ) ) .
342342 '<span class="smw-remove"><a><img src="' . $smwgScriptPath . '/skins/images/close-button.png" alt="' . wfMsg( 'smw_qui_delete' ) . '"></a></span>' .
343343 wfMsg( 'smw_qui_property' ) .
344344 Xml::input( "property_num", '35' ) . " " .
@@ -350,7 +350,7 @@
351351 Xml::closeElement( 'div' );
352352 $hidden_property = json_encode( $hidden_property );
353353
354 - $hidden_category = Html::openElement( 'div', array( 'id' => 'category_starter', 'class' => 'smw-sort', 'style' => 'display:none' ) ) .
 354+ $hidden_category = Html::openElement( 'div', array( 'id' => 'category_starter', 'class' => 'smwsort', 'style' => 'display:none' ) ) .
355355 '<span class="smw-remove"><a><img src="' . $smwgScriptPath . '/skins/images/close-button.png" alt="' . wfMsg( 'smw_qui_delete' ) . '"></a></span>' .
356356 'Category (optional)' . // todo: i18n
357357 Xml::input( "category_num", '20' ) . " " .
@@ -359,7 +359,7 @@
360360 Xml::closeElement( 'div' );
361361 $hidden_category = json_encode( $hidden_category );
362362
363 - $property_dialog_box = Xml::openElement( 'div', array( 'id' => 'prop-dialog', 'title' => 'Property Options', 'class' => 'smw-prop-dialog' ) ) . // todo i18n
 363+ $property_dialog_box = Xml::openElement( 'div', array( 'id' => 'prop-dialog', 'title' => 'Property Options', 'class' => 'smwpropdialog' ) ) . // todo i18n
364364 Xml::inputLabel( 'Property:', '', 'd-property', 'd-property' ) . '<br/>' . // todo i18n
365365 Xml::inputLabel( 'Label:', '', 'd-property-label', 'd-property-label' ) . '<br/>' . // todo i18n
366366 '<label for="d-format">Format:</label> ' . Html::openElement( 'select', array( 'name' => 'd-format', 'id' => 'd-format' ) ) . // todo i18n
@@ -370,7 +370,7 @@
371371 // Xml::inputLabel( 'Limit:', 'd-property-limit', 'd-property-limit' ) . '<br/>' . // todo i18n
372372 '<input type="hidden" name="d-property-code" id="d-property-code">' .
373373 Xml::closeElement( 'div' );
374 - $category_dialog_box = Xml::openElement( 'div', array( 'id' => 'cat-dialog', 'title' => 'Category Options', 'class' => 'smw-cat-dialog' ) ) . // todo i18n
 374+ $category_dialog_box = Xml::openElement( 'div', array( 'id' => 'cat-dialog', 'title' => 'Category Options', 'class' => 'smwcatdialog' ) ) . // todo i18n
375375 Xml::inputLabel( 'Category:', '', 'd-category', 'd-category' ) . '<br/>' . // todo i18n
376376 Xml::inputLabel( 'Label:', '', 'd-category-label', 'd-category-label' ) . '<br/>' . // todo i18n
377377 Xml::inputLabel( 'Yes:', '', 'd-category-yes', 'd-category-yes' ) . '<br/>' . // todo i18n
Index: trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css
@@ -131,22 +131,35 @@
132132 }
133133
134134 /* ui buttons for QueryUI */
135 -.smw-sort input, .smw-sort a, .smw-sort select, .smw-sort checkbox{
 135+.smwsort input, .smwsort a, .smwsort select, .smwsort checkbox{
136136 margin-left: 5px;
137137 margin-bottom: 5px;
138138 }
 139+
139140 span.smw-remove a img{
140141 text-decoration: none;
141142 margin-right: 5px;
142143 vertical-align: -3px;
143144 }
144145
145 -.smw-prop-dialog input, .smw-prop-dialog select{
 146+.smwpropdialog input, .smwpropdialog select{
146147 margin-top: 10px;
147148 margin-right: 5px;
 149+ margin-left: 5px;
148150 }
149151
 152+.smwcatdialog input, .smwcatdialog select{
 153+ margin-top: 10px;
 154+ margin-right: 5px;
 155+ margin-left: 5px;
 156+}
150157
 158+/* Query Creator */
 159+div.smwqcnavbar{
 160+ padding-bottom: 5px;
 161+ padding-top: 5px;
 162+}
 163+
151164 /* search, browse, RDF icons */
152165
153166 span.smwsearchicon { /*FIXME: this was only used for Factbox docu, should be removed from code*/