r94225 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94224‎ | r94225 | r94226 >
Date:02:41, 11 August 2011
Author:neilk
Status:deferred
Tags:
Comment:
the vi API prefix is already taken by some video apis... using id instead
Modified paths:
  • /branches/extensions-realtime/IdentityApi/PROTOCOL (modified) (history)
  • /branches/extensions-realtime/IdentityApi/api/ApiQueryIdentity.php (modified) (history)
  • /branches/extensions-realtime/IdentityApi/api/ApiQueryVerifyIdentity.php (modified) (history)

Diff [purge]

Index: branches/extensions-realtime/IdentityApi/PROTOCOL
@@ -43,15 +43,15 @@
4444
4545
4646 * The Chat service should then use those values to construct its identity verification API call. In particular
47 - note that it uses the API URL again.
 47+ note that it uses the API URL again. Also note that here the arguments are namespaced so we say "idtoken" not "token".
4848
4949 CHAT SERVICE -> WIKI.
5050
5151 http://wiki.ivy.local/w/api.php?
5252 action = verifyidentity
53 - & viuser = Mercury
54 - & vitoken=fafa55405eb0e0336d12135f7f14c9df
55 - & viextras = cookie|wgServer|wgArticlePath|isLoggedIn|username
 53+ & iduser = Mercury
 54+ & idtoken=fafa55405eb0e0336d12135f7f14c9df
 55+ & idextras = cookie|wgServer|wgArticlePath|isLoggedIn|username
5656 & format=json
5757
5858 The extras are information that this chat server might want to know. They should all be self-explanatory,
Index: branches/extensions-realtime/IdentityApi/api/ApiQueryIdentity.php
@@ -11,7 +11,7 @@
1212 */
1313 class ApiQueryIdentity extends ApiQueryBase {
1414 public function __construct( $main, $action ) {
15 - parent::__construct( $main, $action, 'vi' );
 15+ parent::__construct( $main, $action, 'id' );
1616 }
1717
1818 /**
Index: branches/extensions-realtime/IdentityApi/api/ApiQueryVerifyIdentity.php
@@ -11,7 +11,7 @@
1212 */
1313 class ApiQueryVerifyIdentity extends ApiQueryBase {
1414 public function __construct( $main, $action ) {
15 - parent::__construct( $main, $action, 'vi' );
 15+ parent::__construct( $main, $action, 'id' );
1616 }
1717
1818 /**
@@ -78,7 +78,7 @@
7979
8080 protected function getExamples() {
8181 return array (
82 - 'api.php?action=verifyidentity&viuser=NeilK&vitoken=abcdef123456&viextras=avatarSrc|chat|cookie|isStaff|username',
 82+ 'api.php?action=verifyidentity&iduser=NeilK&idtoken=abcdef123456&idextras=avatarSrc|chat|cookie|isStaff|username',
8383 );
8484 }
8585

Status & tagging log