r94205 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94204‎ | r94205 | r94206 >
Date:22:19, 10 August 2011
Author:robin
Status:ok
Tags:
Comment:
Re-add historysubmit, removed in r92984. This broke directionality support when viewing diffs.
Modified paths:
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -410,7 +410,7 @@
411411 # not for special pages or file pages AND only when viewing AND if the page exists
412412 # (or is in MW namespace, because that has default content)
413413 if( !in_array( $this->getTitle()->getNamespace(), array( NS_SPECIAL, NS_FILE ) ) &&
414 - $wgRequest->getVal( 'action', 'view' ) == 'view' &&
 414+ in_array( $wgRequest->getVal( 'action', 'view' ), array( 'view', 'historysubmit' ) ) &&
415415 ( $this->getTitle()->exists() || $this->getTitle()->getNamespace() == NS_MEDIAWIKI ) ) {
416416 $pageLang = $this->getTitle()->getPageLanguage();
417417 $realBodyAttribs = array( 'lang' => $pageLang->getCode(), 'dir' => $pageLang->getDir(),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92984Some misc fixes to Skin and SkinTemplate:...ialex17:05, 24 July 2011

Status & tagging log