r94175 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94174‎ | r94175 | r94176 >
Date:17:59, 10 August 2011
Author:jeroendedauw
Status:deferred
Tags:lamecommitsummary 
Comment:
Modified paths:
  • /trunk/extensions/Maps/Maps.i18n.php (modified) (history)
  • /trunk/extensions/Maps/Maps_Settings.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/GoogleMaps3/Maps_GoogleMaps3.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Maps.i18n.php
@@ -186,6 +186,7 @@
187187 'maps-googlemaps3-par-kml' => 'KML files to load onto the map.',
188188 'maps-googlemaps3-par-gkml' => 'KML files hosted by Google to load onto the map.',
189189 'maps-googlemaps3-par-fusiontables' => 'IDs of Google Fusion Tables which should be loaded onto the map.',
 190+ 'maps-googlemaps3-par-tilt' => 'Tilt for the Map when using Google Maps.',
190191
191192 // OpenLayers
192193 'maps-openlayers-par-controls' => 'The controls to place on the map.',
Index: trunk/extensions/Maps/Maps_Settings.php
@@ -215,6 +215,8 @@
216216
217217 $egMapsGMaps3Layers = array();
218218
 219+ $egMapsGMaps3DefaultTilt = 0;
 220+
219221 $egGoogleJsApiKey = '';
220222
221223
Index: trunk/extensions/Maps/includes/services/GoogleMaps3/Maps_GoogleMaps3.php
@@ -84,7 +84,7 @@
8585 public function addParameterInfo( array &$params ) {
8686 global $egMapsGMaps3Type, $egMapsGMaps3Types, $egMapsGMaps3Controls, $egMapsGMaps3Layers;
8787 global $egMapsGMaps3DefTypeStyle, $egMapsGMaps3DefZoomStyle, $egMapsGMaps3AutoInfoWindows;
88 - global $egMapsResizableByDefault;
 88+ global $egMapsResizableByDefault, $egMapsGMaps3DefaultTilt;
8989
9090 $params['zoom']->addCriteria( new CriterionInRange( 0, 20 ) );
9191 $params['zoom']->setDefault( self::getDefaultZoom() );
@@ -145,10 +145,9 @@
146146 $params['resizable']->setDefault( $egMapsResizableByDefault, false );
147147 $params['resizable']->setMessage( 'maps-par-resizable' );
148148
149 - $egMapsGMaps3DefaultTilt = 15; // TODO
150149 $params['tilt'] = new Parameter( 'tilt', Parameter::TYPE_INTEGER );
151150 $params['tilt']->setDefault( $egMapsGMaps3DefaultTilt, false );
152 - $params['tilt']->setMessage( 'maps-par-tilt' );
 151+ $params['tilt']->setMessage( 'maps-googlemaps3-par-tilt' );
153152 }
154153
155154 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94168finished implementing ge for gm3 and added tilt paramjeroendedauw17:05, 10 August 2011

Status & tagging log