r94169 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94168‎ | r94169 | r94170 >
Date:17:06, 10 August 2011
Author:jeroendedauw
Status:deferred
Tags:lamecommitsummary 
Comment:
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInput.php
@@ -129,9 +129,12 @@
130130
131131 $this->service->addResourceModules( $this->getResourceModules() );
132132
 133+ $configVars = Skin::makeVariablesScript( $this->service->getConfigVariables() );
 134+
133135 if ( true /* !is_null( $wgTitle ) && $wgTitle->isSpecialPage() */ ) { // TODO
134136 global $wgOut;
135137 $this->service->addDependencies( $wgOut );
 138+ $wgOut->addScript( $configVars );
136139 }
137140 else {
138141 $this->service->addDependencies( $wgParser );
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_MapPrinter.php
@@ -192,7 +192,12 @@
193193
194194 $mapName = $this->service->getMapId();
195195
196 - SMWOutputs::requireHeadItem( $mapName, $this->service->getDependencyHtml() );
 196+ SMWOutputs::requireHeadItem(
 197+ $mapName,
 198+ $this->service->getDependencyHtml() .
 199+ $configVars = Skin::makeVariablesScript( $this->service->getConfigVariables() )
 200+ );
 201+
197202 foreach ( $this->service->getResourceModules() as $resourceModule ) {
198203 SMWOutputs::requireResource( $resourceModule );
199204 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r94168finished implementing ge for gm3 and added tilt paramjeroendedauw17:05, 10 August 2011

Status & tagging log