r94053 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94052‎ | r94053 | r94054 >
Date:05:39, 8 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
Minor fix of spacing and accessibility
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -182,7 +182,7 @@
183183 foreach ( $property_values as $i => $property_value ) {
184184
185185 $result .= Html::openElement( 'div', array( 'id' => "sort_div_$i" ) );
186 - $result .= '<span class="smw-remove"> <a href="javascript:removePOInstance(\'sort_div_' . $i . '\')">&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</a></span>';
 186+ $result .= '<span class="smw-remove"><a href="javascript:removePOInstance(\'sort_div_' . $i . '\')"><img src="'.$smwgScriptPath.'/skins/images/close-button.png" alt="'. wfMsg('smw_qui_delete').'"></a></span>';
187187 $result .= wfMsg( 'smw_qui_property' );
188188 $result .= Html::input( 'property[' . $i . ']', $property_value, 'text', array( 'size' => '35' ) ) . "\n";
189189 $result .= Html::openElement( 'select', array( 'name' => "order[$i]" ) );
@@ -206,8 +206,8 @@
207207 // END: create form elements already submitted earlier via form
208208
209209 // create hidden form elements to be cloned later
210 - $hidden = Html::openElement( 'div', array( 'id' => 'sorting_starter', 'style' => 'display:none' ) ) .
211 - '<span class="smw-remove"><a>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;</a></span>' .
 210+ $hidden = Html::openElement( 'div', array( 'id' => 'sorting_starter', 'class'=>'smw-sort', 'style' => 'display:none' ) ) .
 211+ '<span class="smw-remove"><a><img src="'.$smwgScriptPath.'/skins/images/close-button.png" alt="'. wfMsg('smw_qui_delete').'"></a></span>' .
212212 wfMsg( 'smw_qui_property' ) .
213213 Xml::input( "property_num", '35' ) . " ";
214214
@@ -304,7 +304,6 @@
305305 //Create the new instance
306306 var new_div = starter_div.cloneNode(true);
307307 var div_id = 'sort_div_' + num_elements;
308 - new_div.className = 'multipleTemplate';
309308 new_div.id = div_id;
310309 new_div.style.display = 'block';
311310
Index: trunk/extensions/SemanticMediaWiki/skins/SMW_custom.css
@@ -131,13 +131,16 @@
132132 }
133133
134134 /* ui buttons for QueryUI */
135 -span.smw-remove a{
136 - background: url(images/close-button.png) center no-repeat;
137 - height: 16px;
138 - width: 16px;
 135+.smw-sort input, .smw-sort a, .smw-sort select, .smw-sort checkbox{
 136+ margin-left: 5px;
 137+}
 138+span.smw-remove a img{
139139 text-decoration: none;
 140+ margin-right: 5px;
 141+ vertical-align: -3px;
140142 }
141143
 144+
142145 /* search, browse, RDF icons */
143146
144147 span.smwsearchicon { /*FIXME: this was only used for Factbox docu, should be removed from code*/