r94021 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94020‎ | r94021 | r94022 >
Date:11:50, 6 August 2011
Author:reedy
Status:ok
Tags:
Comment:
Remove comment

Improve output of status things
Modified paths:
  • /trunk/extensions/MetricsReporting/fetchGoogleSpreadsheet.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MetricsReporting/fetchGoogleSpreadsheet.php
@@ -45,8 +45,9 @@
4646 }
4747
4848 if ( $authToken === null ) {
49 - $this->error( 'No auth token', true );
 49+ $this->error( 'No auth token returned. Check your Google Credentials', true );
5050 }
 51+ $this->output( 'Authorised. Got an authorisation token from Google' );
5152
5253 $cookies = $http->getCookieJar();
5354 //var_dump( $cookies );
@@ -70,8 +71,6 @@
7172 /**
7273 * Pretty print xml string
7374 *
74 - * From http://recursive-design.com/blog/2007/04/05/format-xml-with-php/
75 - *
7675 * @param $xml string
7776 * @return string
7877 */

Status & tagging log