r94003 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r94002‎ | r94003 | r94004 >
Date:07:01, 6 August 2011
Author:nikerabbit
Status:ok
Tags:
Comment:
Fu r93985, mark functions static because that is how they are called
Modified paths:
  • /trunk/extensions/Translate/tag/PageTranslationHooks.php (modified) (history)
  • /trunk/extensions/WikimediaIncubator/IncubatorTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/tag/PageTranslationHooks.php
@@ -62,7 +62,7 @@
6363 * Set the right page content language for translated pages ("Page/xx")
6464 * and namespaces used for translating messages (similar to MediaWiki namespace pages)
6565 */
66 - function onPageContentLanguage( $title, &$pageLang ) {
 66+ public static function onPageContentLanguage( $title, &$pageLang ) {
6767 global $wgTranslateMessageNamespaces;
6868 // For translation pages, parse plural, grammar etc with correct language, and set the right direction
6969 if ( TranslatablePage::isTranslationPage( $title ) || in_array( $title->getNamespace(), $wgTranslateMessageNamespaces ) ) {
Index: trunk/extensions/WikimediaIncubator/IncubatorTest.php
@@ -631,7 +631,7 @@
632632 return true;
633633 }
634634
635 - function onPageContentLanguage( $title, &$pageLang ) {
 635+ static function onPageContentLanguage( $title, &$pageLang ) {
636636 global $wmincTestWikiNamespaces, $wgOut;
637637 $prefix = self::analyzePrefix( $title->getText(), /* onlyInfoPage*/ false );
638638 if( $prefix['error'] || !in_array( $title->getNamespace(),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93985Use page content language for the WikimediaIncubator and Translate extension....robin16:57, 5 August 2011

Status & tagging log