r93974 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93973‎ | r93974 | r93975 >
Date:14:30, 5 August 2011
Author:siebrand
Status:ok
Tags:
Comment:
whitespace updates and 2 FIXMEs added.
Modified paths:
  • /trunk/extensions/Translate/specials/SpecialImportTranslations.php (modified) (history)
  • /trunk/extensions/Translate/specials/SpecialManageGroups.php (modified) (history)
  • /trunk/extensions/Translate/utils/MessageWebImporter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/MessageWebImporter.php
@@ -251,6 +251,7 @@
252252 $diff = array_diff( $keys, array_keys( $messages ) );
253253
254254 foreach ( $diff as $s ) {
 255+ // @todo FIXME: Use CSS file.
255256 $name = wfMsgHtml( 'translate-manage-import-deleted',
256257 '<code style="font-weight:normal;">' . htmlspecialchars( $s ) . '</code>'
257258 );
Index: trunk/extensions/Translate/specials/SpecialManageGroups.php
@@ -44,7 +44,6 @@
4545 }
4646
4747 if ( $group ) {
48 -
4948 if (
5049 $wgRequest->getBool( 'rebuildall', false ) &&
5150 $wgRequest->wasPosted() &&
@@ -71,6 +70,7 @@
7271 }
7372
7473 }
 74+
7575 // Main list
7676 global $wgLang, $wgOut;
7777
@@ -114,6 +114,7 @@
115115 $out .= $this->rebuildButton( $group, $modified, 'main' );
116116 }
117117 } else {
 118+ // @todo FIXME: should be in CSS file.
118119 $out = Html::rawElement( 'span', array( 'style' => 'color:grey' ), $out );
119120 }
120121 } else {
Index: trunk/extensions/Translate/specials/SpecialImportTranslations.php
@@ -17,7 +17,7 @@
1818 class SpecialImportTranslations extends SpecialPage {
1919 /**
2020 * Set up and fill some dependencies.
21 - */
 21+ */
2222 public function __construct() {
2323 parent::__construct( 'ImportTranslations', 'translate-import' );
2424 global $wgUser, $wgOut, $wgRequest;
@@ -61,7 +61,6 @@
6262 $this->outputForm();
6363 return;
6464 }
65 -
6665 } else {
6766 /**
6867 * Proceed to loading and parsing if possible
@@ -195,6 +194,7 @@
196195 }
197196 } elseif ( $source === 'local' ) {
198197 $filename = $this->request->getFileTempname( 'upload-local' );
 198+
199199 if ( !is_uploaded_file( $filename ) ) {
200200 return array( 'ul-failed' );
201201 }

Status & tagging log