r93966 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93965‎ | r93966 | r93967 >
Date:13:08, 5 August 2011
Author:devayon
Status:deferred
Tags:
Comment:
Minor Ui rearrangement
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_QueryUIHelper.php
@@ -996,8 +996,7 @@
997997 }
998998 }
999999
1000 - $result[0] = "\n<p>" . wfMsg( 'smw_ask_format_as' ) . "\n" .
1001 - '<select id="formatSelector" name="p[format]" onChange="JavaScript:updateOtherOptions(\'' . $url . '\')">' . "\n" .
 1000+ $result[0] = "\n" . '<select id="formatSelector" name="p[format]" onChange="JavaScript:updateOtherOptions(\'' . $url . '\')">' . "\n" .
10021001 '<option value="' . $default_format . '">' . $printer->getName() .
10031002 ' (' . wfMsg( 'smw_ask_defaultformat' ) . ')</option>' . "\n";
10041003
Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -64,11 +64,14 @@
6565 '<input type="hidden" name="title" value="' . $spectitle->getPrefixedText() . '"/>';
6666 $result .= '<br>';
6767 $result .= wfMsg( 'smw_qc_query_help' );
68 - // Main query and printouts.
69 - $result .= '<p><strong>' . wfMsg( 'smw_ask_queryhead' ) . "</strong></p>\n";
70 - $result .= '<p>' . $this->getQueryFormBox() . '</p>';
71 - //format select
72 - $result .= $formatBox[0];
 68+ // Main query and format options
 69+ $result .= '<table style="width: 100%; ">'.
 70+ '<tr><th>' . wfMsg( 'smw_ask_queryhead' ) . "</th>\n<th>" . wfMsg( 'smw_ask_format_as' ) . "</th></tr>".
 71+ '<tr>'.
 72+ '<td style="padding-right: 7px;">'.$this->getQueryFormBox()."</td>\n" .
 73+ '<td style="padding-right: 7px; text-align:center;">'. $formatBox[0] .'</td>'.
 74+ '</tr>'.
 75+ "</table>\n";
7376 // sorting and prinouts
7477 $result .= $this->getPoSortFormBox();
7578 // show|hide additional options and querying help
@@ -284,7 +287,7 @@
285288 });
286289 });
287290 function smw_makeDialog(prop_id){
288 - \$j('#sort-label')[0].value=\$j('#property'+prop_id)[0].value;
 291+ \$j('#tab-property')[0].value=\$j('#property'+prop_id)[0].value;
289292 \$j('#dialog').dialog('open');
290293 }
291294