r93914 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93913‎ | r93914 | r93915 >
Date:21:00, 4 August 2011
Author:demon
Status:ok
Tags:
Comment:
Followup r88270: comment out globals so I can resolve the fixme. Throw an exception here so nobody tries using it anyway
Modified paths:
  • /trunk/phase3/includes/conf/Conf.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/conf/Conf.php
@@ -114,9 +114,10 @@
115115 * @return Conf child
116116 */
117117 public static function load( $wiki = false ) {
 118+ throw new MWException( "Not working yet, don't attempt to use this" );
118119 if( !self::$__instance ) {
119 - global $wgConfiguration;
120 - self::$__instance = self::newFromSettings( $wgConfiguration );
 120+ /**global $wgConfiguration;
 121+ self::$__instance = self::newFromSettings( $wgConfiguration );*/
121122 }
122123 if( $wiki && $wiki != self::$__instance->getWikiId() ) {
123124 // Load configuration for a different wiki, not sure how

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r88270Initial commit of configuration management backend proposal. Feedback desired...demon21:04, 16 May 2011

Status & tagging log