r93859 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93858‎ | r93859 | r93860 >
Date:22:19, 3 August 2011
Author:nad
Status:deferred
Tags:
Comment:
no double escape on quote now that JS in its own file
Modified paths:
  • /trunk/extensions/RecordAdmin/RecordAdmin_body.php (modified) (history)
  • /trunk/extensions/RecordAdmin/recordadmin.js (modified) (history)

Diff [purge]

Index: trunk/extensions/RecordAdmin/recordadmin.js
@@ -9,7 +9,7 @@
1010 var input = jQuery( inputs[k] );
1111 if( input.attr('type') != 'checkbox' || input.attr('checked') ) {
1212 var multi = input.val();
13 - if( typeof( multi ) == 'object' ) multi = multi.join('\\n');
 13+ if( typeof( multi ) == 'object' ) multi = multi.join('\n');
1414 var key = type + ':' + inputs[k].getAttribute('name');
1515 var hidden = jQuery( document.createElement( 'input' ) );
1616 hidden.attr( 'name', key );
Index: trunk/extensions/RecordAdmin/RecordAdmin_body.php
@@ -20,7 +20,6 @@
2121
2222 # Name to use for creating a new record either via RecordAdmin or a public form
2323 $this->guid();
24 -
2524
2625 # Make recordID's of articles created with public forms available via recordid tag
2726 $wgParser->setHook( $wgRecordAdminTag, array( $this, 'expandTag' ) );

Status & tagging log