r93832 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93831‎ | r93832 | r93833 >
Date:15:24, 3 August 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
ake use of setMessage instead of setDescription
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_CSV.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_DSV.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Embedded.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_RDF.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_RSSlink.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QueryPrinter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_RSSlink.php
——@@ -152,10 +152,10 @@
153153 $params = array_merge( parent::getParameters(), $this->exportFormatParameters() );
154154
155155 $params['title'] = new Parameter( 'title' );
156 - $params['title']->setDescription( wfMsg( 'smw_paramdesc_rsstitle' ) );
 156+ $params['title']->setMessage( 'smw_paramdesc_rsstitle' );
157157
158158 $params['description'] = new Parameter( 'title' );
159 - $params['description']->setDescription( wfMsg( 'smw_paramdesc_rssdescription' ) );
 159+ $params['description']->setMessage( 'smw_paramdesc_rssdescription' );
160160
161161 return $params;
162162 }
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_Embedded.php
——@@ -114,11 +114,11 @@
115115 $params = parent::getParameters();
116116
117117 $params['embedformat'] = new Parameter( 'embedformat' );
118 - $params['embedformat']->setDescription( wfMsg( 'smw_paramdesc_embedformat' ) );
 118+ $params['embedformat']->setMessage( 'smw_paramdesc_embedformat' );
119119 $params['embedformat']->setDefault( '' );
120120
121121 $params['embedonly'] = new Parameter( 'embedonly', Parameter::TYPE_BOOLEAN );
122 - $params['embedonly']->setDescription( wfMsg( 'smw_paramdesc_embedonly' ) );
 122+ $params['embedonly']->setMessage( 'smw_paramdesc_embedonly' );
123123 $params['embedonly']->setDefault( '' );
124124
125125 return $params;
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QueryPrinter.php
——@@ -569,15 +569,15 @@
570570 $params = array();
571571
572572 $params['intro'] = new Parameter( 'intro' );
573 - $params['intro']->setDescription( wfMsg( 'smw_paramdesc_intro' ) );
 573+ $params['intro']->setMessage( 'smw_paramdesc_intro' );
574574 $params['intro']->setDefault( '' );
575575
576576 $params['outro'] = new Parameter( 'outro' );
577 - $params['outro']->setDescription( wfMsg( 'smw_paramdesc_outro' ) );
 577+ $params['outro']->setMessage( 'smw_paramdesc_outro' );
578578 $params['outro']->setDefault( '' );
579579
580580 $params['default'] = new Parameter( 'default' );
581 - $params['default']->setDescription( wfMsg( 'smw_paramdesc_default' ) );
 581+ $params['default']->setMessage( 'smw_paramdesc_default' );
582582 $params['default']->setDefault( '' );
583583
584584 return $params;
——@@ -595,7 +595,7 @@
596596 $params = array();
597597
598598 $params['searchlabel'] = new Parameter( 'searchlabel' );
599 - $params['searchlabel']->setDescription( wfMsg( 'smw_paramdesc_searchlabel' ) );
 599+ $params['searchlabel']->setMessage( 'smw_paramdesc_searchlabel' );
600600 $params['searchlabel']->setDefault( false, false );
601601
602602 return $params;
——@@ -634,24 +634,24 @@
635635 $params['format'] = new Parameter( 'format' );
636636
637637 $params['limit'] = new Parameter( 'limit', Parameter::TYPE_INTEGER );
638 - $params['limit']->setDescription( wfMsg( 'smw_paramdesc_limit' ) );
 638+ $params['limit']->setMessage( 'smw_paramdesc_limit' );
639639 $params['limit']->setDefault( 20 );
640640
641641 $params['offset'] = new Parameter( 'offset', Parameter::TYPE_INTEGER );
642 - $params['offset']->setDescription( wfMsg( 'smw_paramdesc_offset' ) );
 642+ $params['offset']->setMessage( 'smw_paramdesc_offset' );
643643 $params['offset']->setDefault( 0 );
644644
645645 $params['headers'] = new Parameter( 'headers' );
646 - $params['headers']->setDescription( wfMsg( 'smw_paramdesc_headers' ) );
 646+ $params['headers']->setMessage( 'smw_paramdesc_headers' );
647647 $params['headers']->addCriteria( new CriterionInArray( 'show', 'hide', 'plain' ) );
648648 $params['headers']->setDefault( 'show' );
649649
650650 $params['mainlabel'] = new Parameter( 'mainlabel' );
651 - $params['mainlabel']->setDescription( wfMsg( 'smw_paramdesc_mainlabel' ) );
 651+ $params['mainlabel']->setMessage( 'smw_paramdesc_mainlabel' );
652652 $params['mainlabel']->setDefault( false, false );
653653
654654 $params['link'] = new Parameter( 'link' );
655 - $params['link']->setDescription( wfMsg( 'smw_paramdesc_link' ) );
 655+ $params['link']->setMessage( 'smw_paramdesc_link' );
656656 $params['link']->addCriteria( new CriterionInArray( 'all', 'subject', 'none' ) );
657657 $params['link']->setDefault( 'all' );
658658
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_CSV.php
——@@ -108,7 +108,7 @@
109109 $params = array_merge( parent::getParameters(), $this->exportFormatParameters() );
110110
111111 $params['sep'] = new Parameter( 'sep' );
112 - $params['sep']->setDescription( wfMsg( 'smw-paramdesc-csv-sep' ) );
 112+ $params['sep']->setMessage( 'smw-paramdesc-csv-sep' );
113113 $params['sep']->setDefault( $this->m_sep );
114114
115115 return $params;
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_List.php
——@@ -302,30 +302,30 @@
303303
304304 if ( $plainlist ) {
305305 $params['sep'] = new Parameter( 'sep' );
306 - $params['sep']->setDescription( wfMsg( 'smw_paramdesc_sep' ) );
 306+ $params['sep']->setMessage( 'smw_paramdesc_sep' );
307307 $params['sep']->setDefault( '' );
308308 }
309309
310310 $params['template'] = new Parameter( 'template' );
311 - $params['template']->setDescription( wfMsg( 'smw_paramdesc_template' ) );
 311+ $params['template']->setMessage( 'smw_paramdesc_template' );
312312 $params['template']->setDefault( '' );
313313
314314 if ( !$plainlist ) {
315315 $params['columns'] = new Parameter( 'columns', Parameter::TYPE_INTEGER );
316 - $params['columns']->setDescription( wfMsg( 'smw_paramdesc_columns', 1 ) );
 316+ $params['columns']->setMessage( 'smw_paramdesc_columns', 1 );
317317 $params['columns']->setDefault( '', false );
318318 }
319319
320320 $params['userparam'] = new Parameter( 'userparam' );
321 - $params['userparam']->setDescription( wfMsg( 'smw_paramdesc_userparam' ) );
 321+ $params['userparam']->setMessage( 'smw_paramdesc_userparam' );
322322 $params['userparam']->setDefault( '' );
323323
324324 $params['introtemplate'] = new Parameter( 'introtemplate' );
325 - $params['introtemplate']->setDescription( wfMsg( 'smw_paramdesc_introtemplate' ) );
 325+ $params['introtemplate']->setMessage( 'smw_paramdesc_introtemplate' );
326326 $params['introtemplate']->setDefault( '' );
327327
328328 $params['outrotemplate'] = new Parameter( 'outrotemplate' );
329 - $params['outrotemplate']->setDescription( wfMsg( 'smw_paramdesc_outrotemplate' ) );
 329+ $params['outrotemplate']->setMessage( 'smw_paramdesc_outrotemplate' );
330330 $params['outrotemplate']->setDefault( '' );
331331
332332 return $params;
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_RDF.php
——@@ -101,7 +101,7 @@
102102 $params = array();
103103
104104 $params['syntax'] = new Parameter( 'syntax' );
105 - $params['syntax']->setDescription( wfMsg( 'smw_paramdesc_rdfsyntax' ) );
 105+ $params['syntax']->setMessage( 'smw_paramdesc_rdfsyntax' );
106106 $params['syntax']->addCriteria( new CriterionInArray( 'rdfxml', 'turtle' ) );
107107 $params['syntax']->setDefault( 'rdfxml' );
108108
Index: trunk/extensions/SemanticMediaWiki/includes/queryprinters/SMW_QP_DSV.php
——@@ -185,11 +185,11 @@
186186 $params = array_merge( parent::getParameters(), $this->exportFormatParameters() );
187187
188188 $params['separator'] = new Parameter( 'separator', 'sep' );
189 - $params['separator']->setDescription( wfMsg( 'smw-paramdesc-dsv-separator' ) );
 189+ $params['separator']->setMessage( 'smw-paramdesc-dsv-separator' );
190190 $params['separator']->setDefault( $this->separator );
191191
192192 $params['filename'] = new Parameter( 'filename' );
193 - $params['filename']->setDescription( wfMsg( 'smw-paramdesc-dsv-filename' ) );
 193+ $params['filename']->setMessage( 'smw-paramdesc-dsv-filename' );
194194 $params['filename']->setDefault( $this->fileName );
195195
196196 return $params;