r93778 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93777‎ | r93778 | r93779 >
Date:20:17, 2 August 2011
Author:neilk
Status:ok
Tags:
Comment:
added a few comments about noAuth
Modified paths:
  • /trunk/phase3/includes/upload/UploadStash.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/upload/UploadStash.php
@@ -10,6 +10,9 @@
1111 * We accomplish this using a database table, with ownership checking as you might expect. See SpecialUploadStash, which
1212 * implements a web interface to some files stored this way.
1313 *
 14+ * UploadStash right now is *mostly* intended to show you one user's slice of the entire stash. The user parameter is only optional
 15+ * because there are few cases where we clean out the stash from an automated script. In the future we might refactor this.
 16+ *
1417 * UploadStash represents the entire stash of temporary files.
1518 * UploadStashFile is a filestore for the actual physical disk files.
1619 * UploadFromStash extends UploadBase, and represents a single stashed file as it is moved from the stash to the regular file repository
@@ -76,6 +79,7 @@
7780
7881 /**
7982 * Get a file and its metadata from the stash.
 83+ * The noAuth param is a bit janky but is required for automated scripts which clean out the stash.
8084 *
8185 * @param $key String: key under which file information is stored
8286 * @param $noAuth Boolean (optional) Don't check authentication. Used by maintenance scripts.

Status & tagging log