r93755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93754‎ | r93755 | r93756 >
Date:14:41, 2 August 2011
Author:flohack
Status:deferred
Tags:
Comment:
Moved a check a bit further down to make creating new lists work again
Modified paths:
  • /trunk/extensions/CollabWatchlist/includes/SpecialCollabWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CollabWatchlist/includes/SpecialCollabWatchlist.php
@@ -146,9 +146,6 @@
147147 $invert = $wgRequest->getBool( 'invert' );
148148 if ( !is_null( $collabWatchlist ) && $collabWatchlist !== 'all' ) {
149149 $collabWatchlist = intval( $collabWatchlist );
150 - } else {
151 - $collabWatchlist = 0;
152 - return;
153150 }
154151 if ( array_key_exists( $collabWatchlist, $listIdsAndNames ) ) {
155152 $wgOut->addHTML( Xml::element( 'h2', null, $listIdsAndNames[$collabWatchlist] ) );
@@ -159,6 +156,8 @@
160157 $editor->execute( $collabWatchlist, $listIdsAndNames, $wgOut, $wgRequest, $mode );
161158 return;
162159 }
 160+ if ( !$collabWatchlist )
 161+ return;
163162
164163 $dbr = wfGetDB( DB_SLAVE, 'watchlist' );
165164 $recentchanges = $dbr->tableName( 'recentchanges' );

Status & tagging log