r93741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93740‎ | r93741 | r93742 >
Date:13:54, 2 August 2011
Author:laner
Status:ok
Tags:
Comment:
Adding patch from Daniel Barrett to remove some warnings, when going to Special:Preferences.
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
——@@ -660,11 +660,11 @@
661661 $retval = true;
662662 }
663663
664 - if ( isset( $wgLDAPUpdateLDAP[$_SESSION['wsDomain']] ) && $wgLDAPUpdateLDAP[$_SESSION['wsDomain']] ) {
 664+ if ( isset( $_SESSION['wsDomain'] ) && isset( $wgLDAPUpdateLDAP[$_SESSION['wsDomain']] ) && $wgLDAPUpdateLDAP[$_SESSION['wsDomain']] ) {
665665 $retval = true;
666666 }
667667
668 - if ( isset( $wgLDAPMailPassword[$_SESSION['wsDomain']] ) && $wgLDAPMailPassword[$_SESSION['wsDomain']] ) {
 668+ if ( isset( $_SESSION['wsDomain'] ) && isset( $wgLDAPMailPassword[$_SESSION['wsDomain']] ) && $wgLDAPMailPassword[$_SESSION['wsDomain']] ) {
669669 $retval = true;
670670 }
671671

Status & tagging log