r93671 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93670‎ | r93671 | r93672 >
Date:22:57, 1 August 2011
Author:demon
Status:ok
Tags:
Comment:
Sqlite fails to open a connection when $user is given.
Reported by lokkju in #wikimedia-tech
Modified paths:
  • /trunk/phase3/includes/db/DatabaseSqlite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/DatabaseSqlite.php
@@ -37,7 +37,7 @@
3838 $this->mName = $dbName;
3939 parent::__construct( $server, $user, $password, $dbName, $flags );
4040 // parent doesn't open when $user is false, but we can work with $dbName
41 - if( !$user && $dbName ) {
 41+ if( $dbName ) {
4242 global $wgSharedDB;
4343 if( $this->open( $server, $user, $password, $dbName ) && $wgSharedDB ) {
4444 $this->attachDatabase( $wgSharedDB );

Status & tagging log