r93632 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93631‎ | r93632 | r93633 >
Date:17:15, 1 August 2011
Author:aaron
Status:ok
Tags:
Comment:
* Fixed undefined $item var in r93512
* Trim each line of .dat file input for sanity
Modified paths:
  • /trunk/tools/mwmultiversion/multiversion/activeMWVersions (modified) (history)
  • /trunk/tools/mwmultiversion/multiversion/switchAllMediaWikis (modified) (history)

Diff [purge]

Index: trunk/tools/mwmultiversion/multiversion/switchAllMediaWikis
@@ -41,8 +41,8 @@
4242
4343 $datList = "";
4444 $count = 0;
45 - foreach ( $verList as $item ) {
46 - $items = explode( ' ', $row );
 45+ foreach ( $verList as $row ) {
 46+ $items = explode( ' ', trim( $row ) );
4747 # Existing values...
4848 $dbName = $items[0];
4949 $version = $items[1];
Index: trunk/tools/mwmultiversion/multiversion/activeMWVersions
@@ -34,8 +34,8 @@
3535 }
3636
3737 $result = $activeVersions = array();
38 - foreach ( $verList as $item ) {
39 - $items = explode( ' ', $row );
 38+ foreach ( $verList as $row ) {
 39+ $items = explode( ' ', trim( $row ) );
4040 $dbName = $items[0];
4141 $version = $items[1];
4242 $extVersion = isset( $items[2] ) ? $items[2] : '';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93512* Changed wikiversions.dat/wikiversions.cdb file to allow for making wikis us...aaron04:53, 30 July 2011

Status & tagging log