r93601 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93600‎ | r93601 | r93602 >
Date:18:00, 31 July 2011
Author:jlemley
Status:deferred
Tags:
Comment:
Fixed monobook bug and SQL issue.
Modified paths:
  • /branches/REL1_16/extensions/Favorites/Favorites.php (modified) (history)
  • /branches/REL1_16/extensions/Favorites/Favorites_body.php (modified) (history)
  • /branches/REL1_16/extensions/Favorites/favorites.sql (modified) (history)

Diff [purge]

Index: branches/REL1_16/extensions/Favorites/Favorites_body.php
@@ -50,7 +50,7 @@
5151 $mode = $favTitle->userIsFavoriting() ? 'unfavorite' : 'favorite';
5252 // See if this object even exists - if the user can't read it, the object doesn't get created.
5353 if ($wgArticle) {
54 - $content_actions['newtab'] = array (
 54+ $content_actions[$mode] = array (
5555 'class' => (( $action == 'favorite' || $action == 'unfavorite' ) ? ' selected' : false ),
5656 'text' => wfMsg( $mode ), // uses 'favorite' or 'unfavorite' message
5757 'href' => $wgArticle->mTitle->getLocalUrl( 'action=' . $mode )
Index: branches/REL1_16/extensions/Favorites/Favorites.php
@@ -22,7 +22,7 @@
2323 'name' => 'Favorites',
2424 'author' => 'Jeremy Lemley',
2525 'descriptionmsg' => 'favorites-desc',
26 - 'version' => '0.0.6',
 26+ 'version' => '0.0.7',
2727 'url' => "http://www.mediawiki.org/wiki/Extension:Favorites",
2828 );
2929
Index: branches/REL1_16/extensions/Favorites/favorites.sql
@@ -10,4 +10,4 @@
1111 fl_notificationtimestamp varbinary(14) DEFAULT NULL,
1212 UNIQUE KEY fl_user (fl_user,fl_namespace,fl_title),
1313 KEY namespace_title (fl_namespace,fl_title)
14 -)
 14+) ;

Status & tagging log