r93598 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93597‎ | r93598 | r93599 >
Date:17:46, 31 July 2011
Author:jlemley
Status:deferred
Tags:
Comment:
Fixed monobook bug, wrapped README.
Modified paths:
  • /trunk/extensions/Favorites/Favorites.php (modified) (history)
  • /trunk/extensions/Favorites/Favorites_body.php (modified) (history)
  • /trunk/extensions/Favorites/README (modified) (history)

Diff [purge]

Index: trunk/extensions/Favorites/Favorites_body.php
@@ -50,7 +50,7 @@
5151 $mode = $favTitle->userIsFavoriting() ? 'unfavorite' : 'favorite';
5252 // See if this object even exists - if the user can't read it, the object doesn't get created.
5353 if ($wgArticle) {
54 - $content_actions['newtab'] = array (
 54+ $content_actions[$mode] = array (
5555 'class' => (( $action == 'favorite' || $action == 'unfavorite' ) ? ' selected' : false ),
5656 'text' => wfMsg( $mode ), // uses 'favorite' or 'unfavorite' message
5757 'href' => $wgArticle->mTitle->getLocalUrl( 'action=' . $mode )
Index: trunk/extensions/Favorites/Favorites.php
@@ -22,7 +22,7 @@
2323 'name' => 'Favorites',
2424 'author' => 'Jeremy Lemley',
2525 'descriptionmsg' => 'favorites-desc',
26 - 'version' => '0.0.6',
 26+ 'version' => '0.0.7',
2727 'url' => "http://www.mediawiki.org/wiki/Extension:Favorites",
2828 );
2929
Index: trunk/extensions/Favorites/README
@@ -1,33 +1,38 @@
2 -This extension provides the ability for users to create a list of favorites. It works separately from the Watchlist, and provides the ability to also embed your users' lists of favorites on a page (such as on the main page).
 2+This extension provides the ability for users to create a list of
 3+favorites. It works separately from the Watchlist, and provides the
 4+ability to also embed your users' lists of favorites on a page (such as
 5+on the main page).
36
 7+== Database schema ==
48
5 -== Database schema ==
 9+A 'favoritelist' table is added to the wiki's database. This table
 10+contains the list of items that have been added to each user's favorite
 11+list.
612
7 -A 'favoritelist' table is added to the wiki's database. This table contains the list of items that have been added to each user's favorite list.
 13+The table must be present for the wiki to function once the extension is
 14+enabled
815
9 -The table must be present for the wiki to function once the extension is enabled
 16+== Installation ==
1017
 18+To enable the extension, add the following line to your
 19+LocalSettings.php file:
1120
12 -== Installation ==
 21+require_once("$IP/extensions/Favorites/Favorites.php");
1322
14 -To enable the extension, add the following line to your LocalSettings.php file:
 23+You must then create and populate the new database table.
1524
16 - require_once("$IP/extensions/Favorites/Favorites.php");
 25+The easiest way to do this is to run MediaWiki's standard updater:
 26+php maintenance/update.php
1727
 28+If you do not have command-line access to your server, you can manually
 29+apply the favorites.sql file's commands to your database (check for
 30+proper table prefix, etc).
1831
19 -You must then create and populate the new database table.
 32+== Configuration Parameters ==
2033
21 -The easiest way to do this is to run MediaWiki's standard updater:
22 -
23 - php maintenance/update.php
 34+If using the Vector skin, you may want to also add the "Star" icon to
 35+your navigation bar. To do this, add the following line '''above''' the
 36+"require_once" line in your LocalSettings.php file:
2437
 38+$wgUseIconFavorite = true;
2539
26 -If you do not have command-line access to your server, you can manually apply the favorites.sql file's commands to your database (check for proper table prefix, etc).
27 -
28 -
29 -== Configuration Parameters ==
30 -
31 -If using the Vector skin, you may want to also add the "Star" icon to your navigation bar. To do this, add the following line '''above''' the "require_once" line in your LocalSettings.php file:
32 -
33 - $wgUseIconFavorite = true;
34 -

Status & tagging log