r93589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93588‎ | r93589 | r93590 >
Date:14:31, 31 July 2011
Author:hartman
Status:resolved
Tags:
Comment:
Reuse $wgAppleTouchIcon, instead of hardcoding it.
Modified paths:
  • /trunk/extensions/MobileFrontend/views/layout/application.html.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MobileFrontend/views/layout/application.html.php
@@ -1,6 +1,12 @@
22 <?php
3 -global $wgExtensionAssetsPath;
 3+global $wgExtensionAssetsPath, $wgAppleTouchIcon;
44
 5+if( $wgAppleTouchIcon !== false ) {
 6+ $appleTouchIconTag = Html::element( 'link', array( 'rel' => 'apple-touch-icon', 'href' => $wgAppleTouchIcon ) );;
 7+} else {
 8+ $appleTouchIconTag = "";
 9+}
 10+
511 $applicationHtml = <<<EOT
612 <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
713 <html lang='{$code}' dir='{$dir}' xml:lang='{$code}' xmlns='http://www.w3.org/1999/xhtml'>
@@ -10,7 +16,7 @@
1117 <link href='{$wgExtensionAssetsPath}/MobileFrontend/stylesheets/{$cssFileName}.css' media='all' rel='Stylesheet' type='text/css' />
1218 <meta name="ROBOTS" content="NOINDEX, NOFOLLOW" />
1319 <meta name = "viewport" content = "width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=0" />
14 - <link rel="apple-touch-icon" href="http://en.m.wikipedia.org/apple-touch-icon.png" />
 20+ ${wgAppleTouchIconTag}
1521 <script type='text/javascript'>
1622 //<![CDATA[
1723 var title = "{$title}";

Follow-up revisions

RevisionCommit summaryAuthorDate
r93597Follow up to r93589hartman17:30, 31 July 2011

Status & tagging log