r93567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93566‎ | r93567 | r93568 >
Date:03:00, 31 July 2011
Author:kaldari
Status:ok
Tags:
Comment:
follow-up to r93566, more foolproof fix
Modified paths:
  • /trunk/extensions/CentralNotice/special/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/special/SpecialBannerController.php
@@ -166,7 +166,7 @@
167167 $script .= "\n\t\tvar url = '" .
168168 Xml::escapeJsString( $wgNoticeFundraisingUrl ) . "';";
169169 $script .= <<<JAVASCRIPT
170 - if ( bannerJson.landingPages && bannerJson.landingPages.length ) {
 170+ if ( ( bannerJson.landingPages !== null ) && bannerJson.landingPages.length ) {
171171 targets = String( bannerJson.landingPages ).split(',');
172172 url += "?" + jQuery.param( {
173173 'landing_page': targets[Math.floor( Math.random() * targets.length )].replace( /^\s+|\s+$/, '' )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93566fix for Bug 30139 - JS error in Chromekaldari02:55, 31 July 2011

Status & tagging log