r93564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93563‎ | r93564 | r93565 >
Date:02:02, 31 July 2011
Author:brion
Status:ok
Tags:
Comment:
MFT r93563: (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL)
Modified paths:
  • /branches/REL1_18/phase3/RELEASE-NOTES-1.18 (modified) (history)
  • /branches/REL1_18/phase3/includes/installer/Installer.php (modified) (history)
  • /branches/REL1_18/phase3/includes/objectcache/ObjectCache.php (modified) (history)

Diff [purge]

Index: branches/REL1_18/phase3/RELEASE-NOTES-1.18
@@ -421,6 +421,7 @@
422422 * (bug 29959) Installer fatal when cURL and allow_url_fopen is disabled and user
423423 tries to subsribe to mediawiki-announce
424424 * Installer checked for magic_quotes_runtime instead of register_globals.
 425+* (bug 30131) XCache with variable caching disabled no longer used for variable caching (CACHE_ACCEL)
425426
426427 === API changes in 1.18 ===
427428 * BREAKING CHANGE: action=watch now requires POST and token.
Index: branches/REL1_18/phase3/includes/objectcache/ObjectCache.php
@@ -93,7 +93,7 @@
9494 $id = 'eaccelerator';
9595 } elseif ( function_exists( 'apc_fetch') ) {
9696 $id = 'apc';
97 - } elseif( function_exists( 'xcache_get' ) ) {
 97+ } elseif( function_exists( 'xcache_get' ) && wfIniGetBool( 'xcache.var_size' ) ) {
9898 $id = 'xcache';
9999 } elseif( function_exists( 'wincache_ucache_get' ) ) {
100100 $id = 'wincache';
Index: branches/REL1_18/phase3/includes/installer/Installer.php
@@ -791,6 +791,9 @@
792792 $caches = array();
793793 foreach ( $this->objectCaches as $name => $function ) {
794794 if ( function_exists( $function ) ) {
 795+ if ( $name == 'xcache' && !wfIniGetBool( 'xcache.var_size' ) ) {
 796+ continue;
 797+ }
795798 $caches[$name] = true;
796799 }
797800 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93563* (bug 30131) XCache with variable caching disabled no longer used for variab...brion01:52, 31 July 2011

Status & tagging log