r93546 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93545‎ | r93546 | r93547 >
Date:17:58, 30 July 2011
Author:kipcool
Status:deferred
Tags:
Comment:
useless join removed
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/SpecialSuggest.php
@@ -248,12 +248,8 @@
249249 // this first query returns the language_id
250250 $sql = 'SELECT language_id' .
251251 " FROM {$dc}_syntrans" .
252 - " JOIN {$dc}_expression ON {$dc}_expression.expression_id = {$dc}_syntrans.expression_id" .
253252 " WHERE {$dc}_syntrans.syntrans_sid = " . $syntransId .
254253 " LIMIT 1 " ;
255 - // not needed: syntransId is unique
256 - // ' AND ' . getLatestTransactionRestriction( "{$dc}_syntrans" ) .
257 - // ' AND ' . getLatestTransactionRestriction( "{$dc}_expression" );
258254 $lang_res = $dbr->query( $sql );
259255 $language_id = $dbr->fetchObject( $lang_res )->language_id;
260256

Status & tagging log