r93540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93539‎ | r93540 | r93541 >
Date:16:38, 30 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Merge in r93533, r93531
Modified paths:
  • /branches/iwtransclusion/phase3v3/includes/LinksUpdate.php (modified) (history)
  • /branches/iwtransclusion/phase3v3/includes/installer/SqliteUpdater.php (modified) (history)

Diff [purge]

Index: branches/iwtransclusion/phase3v3/includes/installer/SqliteUpdater.php
@@ -60,6 +60,11 @@
6161 array( 'addIndex', 'user', 'user_email', 'patch-user_email_index.sql' ),
6262 array( 'addTable', 'config', 'patch-config.sql' ),
6363 array( 'addTable', 'uploadstash', 'patch-uploadstash.sql' ),
 64+
 65+ // 1.19
 66+ array( 'addTable', 'globaltemplatelinks', 'patch-globaltemplatelinks.sql' ),
 67+ array( 'addTable', 'globalnamespaces', 'patch-globalnamespaces.sql' ),
 68+ array( 'addTable', 'globalinterwiki', 'patch-globalinterwiki.sql' ),
6469 );
6570 }
6671
Index: branches/iwtransclusion/phase3v3/includes/LinksUpdate.php
@@ -378,9 +378,15 @@
379379 $this->mDb->delete( $table, $where, __METHOD__ );
380380 }
381381 if ( count( $insertions ) ) {
382 - $this->mDb->insert( 'globaltemplatelinks', $insertions['globaltemplatelinks'], __METHOD__, 'IGNORE' );
383 - $this->mDb->insert( 'globalnamespaces', $insertions['globalnamespaces'], __METHOD__, 'IGNORE' );
384 - $this->mDb->insert( 'globalinterwiki', $insertions['globalinterwiki'], __METHOD__, 'IGNORE' );
 382+ if ( isset( $insertions['globaltemplatelinks'] ) ) {
 383+ $this->mDb->insert( 'globaltemplatelinks', $insertions['globaltemplatelinks'], __METHOD__, 'IGNORE' );
 384+ }
 385+ if ( isset( $insertions['globalnamespaces'] ) ) {
 386+ $this->mDb->insert( 'globalnamespaces', $insertions['globalnamespaces'], __METHOD__, 'IGNORE' );
 387+ }
 388+ if ( isset( $insertions['globalinterwiki'] ) ) {
 389+ $this->mDb->insert( 'globalinterwiki', $insertions['globalinterwiki'], __METHOD__, 'IGNORE' );
 390+ }
385391 }
386392 }
387393
@@ -484,7 +490,7 @@
485491 );
486492 $arr['globalinterwiki'][] = array(
487493 'giw_wikiid' => $wikiid,
488 - 'giw_prefix' => $prefix
 494+ 'giw_prefix' => $prefix // FIXME: $prefix ix undefined
489495 );
490496 $arr['globalnamespaces'][] = array(
491497 'gn_wiki' => wfWikiID( ),

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93531Followup r93530...reedy15:41, 30 July 2011
r93533Add FIXME on undefined variablereedy15:51, 30 July 2011

Status & tagging log