r93454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93453‎ | r93454 | r93455 >
Date:08:02, 29 July 2011
Author:devayon
Status:deferred
Tags:
Comment:
added messages created in r93452. Introduced UI controls made in r93168.
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialQueryCreator.php
@@ -53,7 +53,6 @@
5454 * Creates the input form
5555 *
5656 * @global OutputPage $wgOut
57 - * @global booolean $smwgQSortingSupport
5857 * @return string
5958 */
6059 protected function makeResults() {
@@ -62,32 +61,28 @@
6362 $spectitle = $this->getTitle();
6463 $result .= '<form name="ask" action="' . $spectitle->escapeLocalURL() . '" method="get">' . "\n" .
6564 '<input type="hidden" name="title" value="' . $spectitle->getPrefixedText() . '"/>';
66 -
 65+ $result .= '<br>';
6766 $result .= wfMsg( 'smw_qc_query_help' );
6867 // Main query and printouts.
6968 $result .= '<p><strong>' . wfMsg( 'smw_ask_queryhead' ) . "</strong></p>\n";
70 - $result .= '<p>' . $this->getQueryFormBox( $this->uiCore->getQueryString() ) . '</p>';
 69+ $result .= '<p>' . $this->getQueryFormBox() . '</p>';
 70+ //sorting and prinouts
 71+ $result .= $this->getPoSortFormBox();
7172 // show|hide additional options and querying help
72 - $result .= '<span id="show_additional_options" style="display:inline"><a href="#addtional" rel="nofollow" onclick="' .
 73+ $result .= '<br><span id="show_additional_options" style="display:inline;"><a href="#addtional" rel="nofollow" onclick="' .
7374 "document.getElementById('additional_options').style.display='block';" .
7475 "document.getElementById('show_additional_options').style.display='none';" .
7576 "document.getElementById('hide_additional_options').style.display='inline';" . '">' .
76 - wfMsg( 'smw_show_addnal_opts' ) . '</a></span>';
 77+ wfMsg( 'smw_qc_show_addnal_opts' ) . '</a></span>';
7778 $result .= '<span id="hide_additional_options" style="display:none"><a href="#" rel="nofollow" onclick="' .
7879 "document.getElementById('additional_options').style.display='none';" .
7980 "document.getElementById('hide_additional_options').style.display='none';" .
8081 "document.getElementById('show_additional_options').style.display='inline';" . '">' .
81 - wfMsg( 'smw_hide_addnal_opts' ) . '</a></span>';
 82+ wfMsg( 'smw_qc_hide_addnal_opts' ) . '</a></span>';
8283 $result .= ' | <a href="' . htmlspecialchars( wfMsg( 'smw_ask_doculink' ) ) . '">' . wfMsg( 'smw_ask_help' ) . '</a>';
8384 // additional options
8485 $result .= '<div id="additional_options" style="display:none">';
85 - $result .= '<p><strong>' . wfMsg( 'smw_ask_printhead' ) . "</strong></p>\n" .
86 - '<span style="font-weight: normal;">' . wfMsg( 'smw_ask_printdesc' ) . '</span>' . "\n" .
87 - '<p>' . $this->getPOFormBox( $this->getPOStrings(), SMWQueryUI::ENABLE_AUTO_SUGGEST ) . '</p>' . "\n";
8886
89 - // sorting inputs
90 - $result .= $this->getSortingFormBox();
91 -
9287 $result .= "<br><br>" . $this->getFormatSelectBox( 'broadtable' );
9388
9489 if ( $this->uiCore->getQueryString() != '' ) // hide #ask if there isnt any query defined

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93168preliminary work combining PO and sortingdevayon12:21, 26 July 2011
r93452minor change to Query Creator messagedevayon07:33, 29 July 2011