r93444 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93443‎ | r93444 | r93445 >
Date:01:15, 29 July 2011
Author:mah
Status:ok
Tags:
Comment:
followup r93415 — there is no “$this” in a static method.
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -297,7 +297,6 @@
298298
299299 'AlternateUserMailer': Called before mail is sent so that mail could
300300 be logged (or something else) instead of using PEAR or SMTP
301 -$UserMailer: the EditPage object
302301 $headers: Associative array of headers for the email
303302 $to: MailAddress object or array
304303 $from: From address
Index: trunk/phase3/includes/UserMailer.php
@@ -192,7 +192,7 @@
193193 $headers['X-Mailer'] = 'MediaWiki mailer';
194194 $headers['From'] = $from->toString();
195195
196 - $ret = wfRunHooks( 'AlternateUserMailer', array( $this, $headers, $to, $from, $subject, $body, $replyto, $contentType ) );
 196+ $ret = wfRunHooks( 'AlternateUserMailer', array( $headers, $to, $from, $subject, $body, $replyto, $contentType ) );
197197 if ( $ret === false ) {
198198 return Status::newGood();
199199 } else if ( $ret != true ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93415Add hook that could be the solution for Bug #28026 (“Enable e-mail...mah19:19, 28 July 2011

Status & tagging log