r93428 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93427‎ | r93428 | r93429 >
Date:20:42, 28 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Removed useless $out variable from Skin::getCopyright()
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Skin.php
@@ -741,8 +741,6 @@
742742 $msg = 'copyright';
743743 }
744744
745 - $out = '';
746 -
747745 if ( $wgRightsPage ) {
748746 $title = Title::newFromText( $wgRightsPage );
749747 $link = Linker::linkKnown( $title, $wgRightsText );
@@ -752,7 +750,7 @@
753751 $link = $wgRightsText;
754752 } else {
755753 # Give up now
756 - return $out;
 754+ return '';
757755 }
758756
759757 // Allow for site and per-namespace customization of copyright notice.
@@ -761,12 +759,10 @@
762760 wfRunHooks( 'SkinCopyrightFooter', array( $this->getTitle(), $type, &$msg, &$link, &$forContent ) );
763761
764762 if ( $forContent ) {
765 - $out .= wfMsgForContent( $msg, $link );
 763+ return wfMsgForContent( $msg, $link );
766764 } else {
767 - $out .= wfMsg( $msg, $link );
 765+ return wfMsg( $msg, $link );
768766 }
769 -
770 - return $out;
771767 }
772768
773769 function getCopyrightIcon() {

Status & tagging log