r93406 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r93405‎ | r93406 | r93407 >
Date:18:01, 28 July 2011
Author:ialex
Status:ok
Tags:
Comment:
Passing a string to DifferenceEngine's constructor is really not a good idea since it expects a Title object or null
Modified paths:
  • /trunk/extensions/AbuseFilter/special/SpecialAbuseLog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/AbuseFilter/special/SpecialAbuseLog.php
——@@ -265,7 +265,7 @@
266266 $old_wikitext = $vars->getVar( 'old_wikitext' )->toString();
267267 $new_wikitext = $vars->getVar( 'new_wikitext' )->toString();
268268
269 - $diffEngine = new DifferenceEngine( $this->mSearchTitle );
 269+ $diffEngine = new DifferenceEngine;
270270
271271 $diffEngine->showDiffStyle();
272272 $formattedDiff = $diffEngine->generateDiffBody( $old_wikitext, $new_wikitext );

Status & tagging log