r93381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93380‎ | r93381 | r93382 >
Date:10:56, 28 July 2011
Author:reedy
Status:ok
Tags:
Comment:
Followup r93222

Fix error which causes error

Add 2 bits of documentation
Modified paths:
  • /trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/api/ApiQueryCodeRevisions.php
@@ -98,6 +98,12 @@
9999 $result->addValue( 'query', $this->getModuleName(), $data );
100100 }
101101
 102+ /**
 103+ * @param $row
 104+ * @param $repo CodeRepository
 105+ * @param $result ApiResult
 106+ * @return array
 107+ */
102108 private function formatRow( $row, $repo, $result ) {
103109 $item = array();
104110 if ( isset( $this->props['revid'] ) ) {
@@ -124,7 +130,7 @@
125131 if ( isset( $this->props['tags'] ) ) {
126132 $rev = CodeRevision::newFromRow( $repo, $row );
127133 $item['tags'] = $rev->getTags( );
128 - $result->setIndexedTagName( $item, 'tags' );
 134+ $result->setIndexedTagName( $item['tags'], 'tags' );
129135 }
130136 return $item;
131137 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r93222Add param to code review api so that tags for a revision are also...mah17:32, 26 July 2011

Status & tagging log