r93193 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93192‎ | r93193 | r93194 >
Date:15:19, 26 July 2011
Author:reedy
Status:ok
Tags:
Comment:
* (bug 29684) Set forgotten parameter types in ApiQueryIWLinks
Modified paths:
  • /trunk/phase3/RELEASE-NOTES-1.19 (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryIWLinks.php (modified) (history)

Diff [purge]

Index: trunk/phase3/RELEASE-NOTES-1.19
@@ -29,6 +29,7 @@
3030 === API changes in 1.19 ===
3131 * (bug 19838) siprop=interwikimap can now use the interwiki cache.
3232 * (bug 29748) Add API search prefix support
 33+* (bug 29684) Set forgotten parameter types in ApiQueryIWLinks
3334
3435 === Languages updated in 1.19 ===
3536
Index: trunk/phase3/includes/api/ApiQueryIWLinks.php
@@ -109,7 +109,7 @@
110110 }
111111 $entry = array( 'prefix' => $row->iwl_prefix );
112112
113 - if ( !is_null( $params['url'] ) ) {
 113+ if ( $params['url'] ) {
114114 $title = Title::newFromText( "{$row->iwl_prefix}:{$row->iwl_title}" );
115115 if ( $title ) {
116116 $entry['url'] = wfExpandUrl( $title->getFullURL() );
@@ -131,7 +131,7 @@
132132
133133 public function getAllowedParams() {
134134 return array(
135 - 'url' => null,
 135+ 'url' => false,
136136 'limit' => array(
137137 ApiBase::PARAM_DFLT => 10,
138138 ApiBase::PARAM_TYPE => 'limit',

Status & tagging log