r93183 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93182‎ | r93183 | r93184 >
Date:14:28, 26 July 2011
Author:raymond
Status:ok
Tags:
Comment:
* Followup r91063: Tweak extensions credit and message file for consistency.
* Replace 1 German word in the 'en' section with the English word
* Use special page alias w/o spaces for consistency, replace space with _ to be sure it works well. IIRC spaces are forbidden
* Use more modern $specialPageAliases
* Add extension to translatewiki.net
Modified paths:
  • /trunk/extensions/CollabWatchlist/CollabWatchlist.alias.php (modified) (history)
  • /trunk/extensions/CollabWatchlist/CollabWatchlist.i18n.php (modified) (history)
  • /trunk/extensions/CollabWatchlist/CollabWatchlist.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -231,6 +231,9 @@
232232 ignored = code-rev-comment-preview-accesskey, code-rev-submit-accesskey, code-rev-submit-next-accesskey
233233 ignored = code-rev-id, code-rev-next-accesskey
234234
 235+Collab Watchlist
 236+ignored = collabwatchlist-unset-tag
 237+
235238 Collection - Core
236239 id = ext-collection-core
237240 file = Collection/CollectionCore.i18n.php
Index: trunk/extensions/CollabWatchlist/CollabWatchlist.i18n.php
@@ -1,20 +1,30 @@
22 <?php
 3+/**
 4+ * Internationalisation file for Collaborative watchlist extension.
 5+ *
 6+ * @file
 7+ * @ingroup Extensions
 8+ */
 9+
310 $messages = array();
411
 12+/** English
 13+ * @author Florian Hackenberger
 14+ */
515 $messages['en'] = array(
616 'collabwatchlist' => 'Collaborative watchlist',
 17+ 'collabwatchlist-desc' => 'Provides collaborative watchlists based on categories',
718 'specialcollabwatchlist' => 'Collaborative watchlist special page',
8 - 'specialcollabwatchlist-desc' => 'Collaborative watchlist special page description',
919 'collabwatchlist-details' => '{{PLURAL:$1|$1 category/page|$1 categories/pages}} on this collaborative watchlist.',
1020 'collabwatchlisttagselect' => 'Tag',
1121 'collabwatchlisttagcomment' => 'Comment',
1222 'collabwatchlistsettagbutton' => 'Set tag',
1323 'collabwatchlist-unset-tag' => 'x',
1424 'collabwatchlisttools-view' => 'Display',
15 - 'collabwatchlisttools-edit' => 'Edit Categories',
16 - 'collabwatchlisttools-rawCategories' => 'Raw Edit Categories',
17 - 'collabwatchlisttools-rawTags' => 'Raw Edit Tags',
18 - 'collabwatchlisttools-rawUsers' => 'Raw Edit Users',
 25+ 'collabwatchlisttools-edit' => 'Edit categories',
 26+ 'collabwatchlisttools-rawCategories' => 'Raw edit categories',
 27+ 'collabwatchlisttools-rawTags' => 'Raw edit tags',
 28+ 'collabwatchlisttools-rawUsers' => 'Raw edit users',
1929 'collabwatchlisttools-delete' => 'Delete',
2030 'collabwatchlistsall' => 'All lists',
2131 'collabwatchlistfiltertags' => 'Filter tags',
@@ -65,11 +75,14 @@
6676 'collabwatchlistedit-raw-done' => 'The collaborative watchlist has been updated',
6777 'collabwatchlistedit-raw-added' => '{{PLURAL:$1|1 page/category was|$1 pages/categories were}} added:',
6878 'collabwatchlistedit-raw-removed' => '{{PLURAL:$1|1 page/category was|$1 pages/categories were}} removed',
69 - 'collabwatchlistedit-normal-submit' => 'Speichern',
 79+ 'collabwatchlistedit-normal-submit' => 'Save',
7080 'collabwatchlistshowhidelistusers' => '$1 list users',
7181 'tog-collabwatchlisthidelistusers' => 'Hide edits from collaborative watchlist users',
7282 );
7383
 84+/** English
 85+ * @author Florian Hackenberger
 86+ */
7487 $messages['de'] = array(
7588 'collabwatchlist' => 'Kollaborative Beobachtungsliste',
7689 'specialcollabwatchlist' => 'Kollaborative Beobachtungsliste Spezialseite',
@@ -138,3 +151,4 @@
139152 'collabwatchlistshowhidelistusers' => 'Listenbenutzer $1',
140153 'tog-collabwatchlisthidelistusers' => 'Bearbeitungen von Benutzern der kollaborativen Beobachtungsliste ausblenden',
141154 );
 155+
Index: trunk/extensions/CollabWatchlist/CollabWatchlist.php
@@ -10,11 +10,11 @@
1111
1212
1313 $wgExtensionCredits['specialpage'][] = array(
 14+ 'path' => __FILE__,
1415 'name' => 'CollabWatchlist',
1516 'author' => 'Florian Hackenberger',
1617 'url' => 'http://www.mediawiki.org/wiki/User:Flohack',
17 - 'description' => 'Provides collaborative watchlists based on categories',
18 - 'descriptionmsg' => 'specialcollabwatchlist-desc',
 18+ 'descriptionmsg' => 'collabwatchlist-desc',
1919 'version' => '0.9.0',
2020 );
2121
Index: trunk/extensions/CollabWatchlist/CollabWatchlist.alias.php
@@ -5,18 +5,19 @@
66 * @addtogroup Extensions
77 */
88
9 -$aliases = array();
 9+$specialPageAliases = array();
1010
1111 /** English
12 - * @author Aaron Schulz
 12+ * @author Florian Hackenberger
1313 */
14 -$aliases['en'] = array(
15 - 'Collabwatchlist' => array( 'Collaborative watchlist' ),
 14+$specialPageAliases['en'] = array(
 15+ 'Collabwatchlist' => array( 'CollaborativeWatchlist' ),
1616 );
1717
1818 /** German (Deutsch)
19 - * @author Raimond Spekking
 19+ * @author Florian Hackenberger
2020 */
21 -$aliases['de'] = array(
22 - 'Collabwatchlist' => array( 'Kollaborative Beobachtungsliste' ),
 21+$specialPageAliases['de'] = array(
 22+ 'Collabwatchlist' => array( 'Kollaborative_Beobachtungsliste' ),
2323 );
 24+

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r91063Added the CollabWatchlist extension. See http://www.mediawiki.org/wiki/Extens...flohack10:12, 29 June 2011

Status & tagging log