r93164 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93163‎ | r93164 | r93165 >
Date:07:47, 26 July 2011
Author:nad
Status:deferred
Tags:
Comment:
more JS inclusion issues, working in 1.17+ now and <1.17
Modified paths:
  • /trunk/extensions/TreeAndMenu/TreeAndMenu.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TreeAndMenu/TreeAndMenu.php
@@ -14,7 +14,7 @@
1515
1616 if ( !defined( 'MEDIAWIKI' ) ) die( 'Not an entry point.' );
1717
18 -define( 'TREEANDMENU_VERSION','1.2.3, 2011-07-26' );
 18+define( 'TREEANDMENU_VERSION','1.2.4, 2011-07-26' );
1919
2020 # Set any unset images to default titles
2121 if ( !isset( $wgTreeViewImages ) || !is_array( $wgTreeViewImages ) ) $wgTreeViewImages = array();
@@ -221,9 +221,13 @@
222222 $$pos .= "<a href=\"javascript: $objid.{$arg}All();\">&#160;{$arg} all</a>&#160;";
223223 if ( $top ) $top = "<p>&#160;$top</p>";
224224 if ( $bottom ) $bottom = "<p>&#160;$bottom</p>";
225 - $html = "$top<div class='$class' id='$id'>
 225+
 226+ # Add the dTRee script if not loaded yet
 227+ $dTreeScript = $this->js++ ? "" : "<script type=\"$wgJsMimeType\" src=\"{$this->baseUrl}/dtree.js\"></script>";
 228+
 229+ $html = "$top<div class='$class' id='$id'>$dTreeScript
226230 <script type=\"$wgJsMimeType\">/*<![CDATA[*/
227 - // TreeAndMenu{$this->version}
 231+ // TreeAndMenu-{$this->version}
228232 tree = new dTree('$objid');
229233 for (i in tree.icon) tree.icon[i] = '{$this->baseUrl}/'+tree.icon[i];{$this->images}
230234 tree.config.useLines = {$this->useLines};
@@ -260,12 +264,7 @@
261265 }
262266 }
263267 }
264 -
265268 $text = preg_replace( "/\x7f1$u\x7f.+?[\\r\\n]+/m", '', $text ); # Remove all unreplaced row information
266 -
267 - # Add the dTRee script if not loaded yet
268 - if( !$this->js++ ) $text = "<script type=\"$wgJsMimeType\" src=\"{$this->baseUrl}/dtree.js\"></script>\n$text";
269 -
270269 return true;
271270 }
272271

Status & tagging log