r93126 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93125‎ | r93126 | r93127 >
Date:21:41, 25 July 2011
Author:jeroendedauw
Status:deferred
Tags:
Comment:
added missing msg arg
Modified paths:
  • /trunk/extensions/SemanticWatchlist/SemanticWatchlist.hooks.php (modified) (history)
  • /trunk/extensions/SemanticWatchlist/includes/SWL_Emailer.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticWatchlist/includes/SWL_Emailer.php
@@ -49,10 +49,13 @@
5050 $emailText .= self::getChangeListHTML( $changeSet );
5151 }
5252
53 - //echo $emailText;exit;
 53+ $title = wfMsgReal(
 54+ 'swl-email-propschanged',
 55+ array( $changeSet->getEdit()->getTitle()->getFullText() ),
 56+ true,
 57+ $user->getOption( 'language' )
 58+ );
5459
55 - $title = wfMsgReal( 'swl-email-propschanged', array(), true, $user->getOption( 'language' ) );
56 -
5760 wfRunHooks( 'SWLBeforeEmailNotify', array( $group, $user, $changeSet, $describeChanges, &$title, &$emailText ) );
5861
5962 return $user->sendMail(
Index: trunk/extensions/SemanticWatchlist/SemanticWatchlist.hooks.php
@@ -77,7 +77,6 @@
7878 $user = User::newFromId( $userID );
7979
8080 if ( $user->getOption( 'swl_email', false ) ) {
81 -
8281 if ( !method_exists( 'Sanitizer', 'validateEmail' ) || Sanitizer::validateEmail( $user->getEmail() ) ) {
8382 $lastNotify = $user->getOption( 'swl_last_notify' );
8483 $lastWatch = $user->getOption( 'swl_last_watch' );