r93089 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93088‎ | r93089 | r93090 >
Date:19:01, 25 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Improved error messages from r92844
Modified paths:
  • /trunk/tools/mwmultiversion/multiversion/refreshWikiversionsCDB (modified) (history)

Diff [purge]

Index: trunk/tools/mwmultiversion/multiversion/refreshWikiversionsCDB
@@ -21,7 +21,7 @@
2222 # Build new database at temp location...
2323 $db = dba_open( $tmpDBPath, "n", "cdb_make" );
2424 if ( !$db ) {
25 - die( "Unable to create wikiversions.cdb.\n" );
 25+ die( "Unable to create wikiversions.cdb.tmp.\n" );
2626 }
2727 foreach ( $verList as $row ) {
2828 list( $dbName, $version ) = explode( ' ', $row );
@@ -37,7 +37,7 @@
3838 # Move to final location only when finished...
3939 @unlink( $finalDBPath );
4040 if ( !rename( $tmpDBPath, $finalDBPath ) ) {
41 - die( "Unable to create wikiversions.cdb.\n" );
 41+ die( "Unable to move wikiversions.cdb.tmp to wikiversions.cdb.\n" );
4242 }
4343 }
4444

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92844Refactored cdb handling so that we have a dat and a cdb file. refreshWikivers...aaron02:00, 22 July 2011

Status & tagging log