r93075 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93074‎ | r93075 | r93076 >
Date:18:05, 25 July 2011
Author:aaron
Status:ok
Tags:
Comment:
Marked canChangePassword protected, w/s fixes
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPasswordReset.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPasswordReset.php
@@ -212,12 +212,13 @@
213213 $this->getOutput()->returnToMain();
214214 }
215215
216 - function canChangePassword( User $user ) {
 216+ protected function canChangePassword( User $user ) {
217217 global $wgPasswordResetRoutes, $wgAuth;
218218
219219 // Maybe password resets are disabled, or there are no allowable routes
220220 if ( !is_array( $wgPasswordResetRoutes ) ||
221 - !in_array( true, array_values( $wgPasswordResetRoutes ) ) ) {
 221+ !in_array( true, array_values( $wgPasswordResetRoutes ) ) )
 222+ {
222223 return 'passwordreset-disabled';
223224 }
224225
@@ -235,7 +236,6 @@
236237 return true;
237238 }
238239
239 -
240240 /**
241241 * Hide the password reset page if resets are disabled.
242242 * @return Bool
@@ -249,4 +249,4 @@
250250
251251 return false;
252252 }
253 -}
\ No newline at end of file
 253+}

Status & tagging log