r9306 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9305‎ | r9306 | r9307 >
Date:03:12, 2 June 2005
Author:vibber
Status:old
Tags:
Comment:
* Removed -f parameter from mail() usage, likely to cause failures and bounces.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/UserMailer.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/UserMailer.php
@@ -93,8 +93,7 @@
9494
9595 $wgErrorString = '';
9696 set_error_handler( 'mailErrorHandler' );
97 - # added -f parameter, see PHP manual for the fifth parameter when using the mail function
98 - mail( $to, $subject, $body, $headers, " -f {$wgEmergencyContact}\n");
 97+ mail( $to, $subject, $body, $headers );
9998 restore_error_handler();
10099
101100 if ( $wgErrorString ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -237,6 +237,7 @@
238238 leaves the whitespace from the section comment there on preview.
239239 * (bug 2274) Respect stub threshold in category page list
240240 * (bug 2173) Fatal error when removing an article with an empty title from the watchlist
 241+* Removed -f parameter from mail() usage, likely to cause failures and bounces.
241242
242243
243244 === Caveats ===

Status & tagging log