r93045 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r93044‎ | r93045 | r93046 >
Date:08:58, 25 July 2011
Author:krinkle
Status:ok
Tags:
Comment:
Removing redundant check from $.fn.goIn/Out code.
Modified paths:
  • /trunk/phase3/resources/mediawiki/mediawiki.htmlform.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/mediawiki/mediawiki.htmlform.js
@@ -10,7 +10,7 @@
1111 * @return jQuery
1212 */
1313 $.fn.goIn = function( instantToggle ) {
14 - if ( instantToggle !== undefined && instantToggle === true ) {
 14+ if ( instantToggle === true ) {
1515 return $(this).show();
1616 }
1717 return $(this).stop( true, true ).fadeIn();
@@ -23,7 +23,7 @@
2424 * @return jQuery
2525 */
2626 $.fn.goOut = function( instantToggle ) {
27 - if ( instantToggle !== undefined && instantToggle === true ) {
 27+ if ( instantToggle === true ) {
2828 return $(this).hide();
2929 }
3030 return $(this).stop( true, true ).fadeOut();

Status & tagging log