r9304 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9303‎ | r9304 | r9305 >
Date:00:26, 2 June 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2173) Fatal error when removing an article with an empty title from
the watchlist
Modified paths:
  • /branches/REL1_4/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_4/phase3/includes/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: branches/REL1_4/phase3/includes/SpecialWatchlist.php
@@ -42,7 +42,7 @@
4343 $wgOut->addHTML( wfMsg( "removingchecked" ) );
4444 foreach($id as $one) {
4545 $t = Title::newFromURL( $one );
46 - if($t->getDBkey() != "") {
 46+ if( !is_null( $t ) ) {
4747 $wl = WatchedItem::fromUserTitle( $wgUser, $t );
4848 if( $wl->removeWatch() === false ) {
4949 $wgOut->addHTML( "<br />\n" . wfMsg( "couldntremove", htmlspecialchars($one) ) );
Index: branches/REL1_4/phase3/RELEASE-NOTES
@@ -610,6 +610,7 @@
611611 * Fix sorting of profiling output in debug log: largest last for easy tailing
612612 * (bug 2281) Fix regression with page moves taking the wrong talk pages
613613 * Regression fix: watchlist day cutoff
 614+* (bug 2173) Fatal error when removing an article with an empty title from the watchlist
614615
615616
616617 === Caveats ===

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r9303* (bug 2173) Fatal error when removing an article with an empty title from...vibber00:24, 2 June 2005

Status & tagging log