r9303 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r9302‎ | r9303 | r9304 >
Date:00:24, 2 June 2005
Author:vibber
Status:old
Tags:
Comment:
* (bug 2173) Fatal error when removing an article with an empty title from
the watchlist
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SpecialWatchlist.php
@@ -50,7 +50,7 @@
5151 $wgOut->addHTML( '<p>' );
5252 foreach($id as $one) {
5353 $t = Title::newFromURL( $one );
54 - if($t->getDBkey() != '') {
 54+ if( !is_null( $t ) ) {
5555 $wl = WatchedItem::fromUserTitle( $wgUser, $t );
5656 if( $wl->removeWatch() === false ) {
5757 $wgOut->addHTML( "<br />\n" . wfMsg( 'couldntremove', htmlspecialchars($one) ) );
Index: trunk/phase3/RELEASE-NOTES
@@ -235,6 +235,8 @@
236236 * (bug 2275) Update search index more or less right on page move
237237 * (bug 2053) Move comment whitespace trimming from edit page to save;
238238 leaves the whitespace from the section comment there on preview.
 239+* (bug 2274) Respect stub threshold in category page list
 240+* (bug 2173) Fatal error when removing an article with an empty title from the watchlist
239241
240242
241243 === Caveats ===

Follow-up revisions

RevisionCommit summaryAuthorDate
r9304* (bug 2173) Fatal error when removing an article with an empty title from...vibber00:26, 2 June 2005

Status & tagging log