r92973 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92972‎ | r92973 | r92974 >
Date:23:42, 23 July 2011
Author:robin
Status:ok
Tags:
Comment:
Pass default url as parameter for wgRequest->getVal( 'wpInterwikiURL' ) per ^demon on r92672. Also for wgRequest->getVal( 'prefix' ) alternative of wgRequest->getVal( 'wpInterwikiPrefix' ).
Modified paths:
  • /trunk/extensions/Interwiki/Interwiki_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Interwiki/Interwiki_body.php
@@ -116,14 +116,12 @@
117117 $intromessage = wfMessage( 'interwiki_editintro' )->text();
118118 $button = 'edit';
119119 } elseif( $action == 'add' ) {
120 - $prefix = $wgRequest->getVal( 'wpInterwikiPrefix' ) ?
121 - $wgRequest->getVal( 'wpInterwikiPrefix' ) : $wgRequest->getVal( 'prefix' );
 120+ $prefix = $wgRequest->getVal( 'wpInterwikiPrefix', $wgRequest->getVal( 'prefix' ) );
122121 $prefix = Xml::input( 'wpInterwikiPrefix', 20, $prefix,
123122 array( 'tabindex' => 1, 'id' => 'mw-interwiki-prefix', 'maxlength' => 20 ) );
124123 $local = $wgRequest->getCheck( 'wpInterwikiLocal' );
125124 $trans = $wgRequest->getCheck( 'wpInterwikiTrans' );
126 - $defaulturl = $wgRequest->getVal( 'wpInterwikiURL' ) ?
127 - $wgRequest->getVal( 'wpInterwikiURL' ) : wfMessage( 'interwiki-defaulturl' )->text();
 125+ $defaulturl = $wgRequest->getVal( 'wpInterwikiURL', wfMessage( 'interwiki-defaulturl' )->text() );
128126 $topmessage = wfMessage( 'interwiki_addtext' )->text();
129127 $intromessage = wfMessage( 'interwiki_addintro' )->text();
130128 $button = 'interwiki_addbutton';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r92672fixes for r92636robin19:58, 20 July 2011

Status & tagging log