r92821 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92820‎ | r92821 | r92822 >
Date:23:02, 21 July 2011
Author:krinkle
Status:deferred
Tags:
Comment:
MoodBar front-end dev:
- states
Modified paths:
  • /trunk/extensions/MoodBar/MoodBar.i18n.php (modified) (history)
  • /trunk/extensions/MoodBar/MoodBar.php (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css (modified) (history)
  • /trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js (modified) (history)

Diff [purge]

Index: trunk/extensions/MoodBar/MoodBar.i18n.php
@@ -46,7 +46,8 @@
4747 'moodbar-form-policy-label' => 'our policy',
4848 'moodbar-loading-title' => 'Sharing...',
4949 'moodbar-success-title' => 'Thanks!',
50 - 'moodbar-error-title' => 'Sharing...',
 50+ 'moodbar-error-title' => 'Oops!',
 51+ 'moodbar-success-subtitle' => '@todo',
5152 // Special:MoodBar
5253 'right-moodbar-view' => 'View and export MoodBar feedback',
5354 'moodbar-admin-title' => 'MoodBar feedback',
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.css
@@ -80,6 +80,29 @@
8181 float: right;
8282 }
8383
 84+.mw-moodBar-form {
 85+ padding-right: 5px;
 86+}
 87+.mw-moodBar-formInputs {
 88+ padding-left: 2em;
 89+}
 90+
 91+.mw-moodBar-state-loading {
 92+ background: url(images/ajax-spinner.gif) left center no-repeat;
 93+ padding: 20px 0 0 90px;
 94+ height: 77px;
 95+}
 96+
 97+.mw-moodBar-state-title {
 98+ font-weight: bold;
 99+ font-size: 25px;
 100+}
 101+
 102+.mw-moodBar-state-subtitle {
 103+ font-size: 14px;
 104+ color: #7e7e7e;
 105+}
 106+
84107 /**
85108 * Types
86109 */
@@ -134,18 +157,3 @@
135158 .mw-moodBar-types-select .mw-moodBar-type-confused.mw-moodBar-selected {
136159 background-image: url(images/type-confused-selected.png);
137160 }
138 -
139 -.mw-moodBar-form {
140 - padding-right: 5px;
141 -}
142 -.mw-moodBar-formInputs {
143 - padding-left: 2em;
144 -}
145 -
146 -.mw-moodBar-loading {
147 - background-image: url(images/ajax-spinner.gif);
148 - background-position: left center;
149 - background-repeat: no-repeat;
150 - padding-left: 70px;
151 - height: 70px;
152 -}
Index: trunk/extensions/MoodBar/modules/ext.moodBar/ext.moodBar.core.js
@@ -40,11 +40,18 @@
4141 <span class="mw-moodBar-typeTitle"><html:msg key="moodbar-type-$1-title" /></span>\
4242 </div>',
4343 loading: '\
44 - <div class="mw-moodBar-loading"><html:msg key="moodbar-loading-title"/></div>',
 44+ <div class="mw-moodBar-state mw-moodBar-state-loading">\
 45+ <div class="mw-moodBar-state-title"><html:msg key="moodbar-loading-title" /></div>\
 46+ </div>',
4547 success: '\
46 - <div><html:msg key="moodbar-success-title" /></div>',
 48+ <div class="mw-moodBar-state mw-moodBar-state-success">\
 49+ <div class="mw-moodBar-state-title"><html:msg key="moodbar-success-title" /></div>\
 50+ <div class="mw-moodBar-state-subtitle"><html:msg key="moodbar-success-subtitle" /></div>\
 51+ </div>',
4752 error: '\
48 - <div><html:msg key="moodbar-error-title" /></div>'
 53+ <div class="mw-moodBar-state mw-moodBar-state-error">\
 54+ <div class="mw-moodBar-state-title"><html:msg key="moodbar-error-title" /></div>\
 55+ </div>'
4956 },
5057
5158 event: {
@@ -208,7 +215,7 @@
209216 .click( function() {
210217 mb.feedbackItem.comment = mb.ui.overlay.find( '.mw-moodBar-formInput' ).val();
211218 mb.swapContent( mb.tpl.loading );
212 - //$.moodBar.submit( mb.feedbackItem );
 219+ $.moodBar.submit( mb.feedbackItem );
213220 } )
214221 .end();
215222
Index: trunk/extensions/MoodBar/MoodBar.php
@@ -90,6 +90,7 @@
9191 'moodbar-loading-title',
9292 'moodbar-error-title',
9393 'moodbar-success-title',
 94+ 'moodbar-success-subtitle',
9495 ),
9596 'dependencies' => array(
9697 'mediawiki.util',

Status & tagging log