r92710 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r92709‎ | r92710 | r92711 >
Date:23:27, 20 July 2011
Author:demon
Status:ok
Tags:
Comment:
Revert DatabaseBase::tablePrefix() part of r79272: doesn't seem to be really necessary (tests are all still passing, Mysql && Sqlite) and as Tim points out this breaks anything trying to use it as an accessor rather than mutator.
Modified paths:
  • /trunk/phase3/includes/db/Database.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/Database.php
——@@ -324,7 +324,7 @@
325325 * @return The previous table prefix.
326326 */
327327 function tablePrefix( $prefix = null ) {
328 - return wfSetVar( $this->mTablePrefix, $prefix, true );
 328+ return wfSetVar( $this->mTablePrefix, $prefix );
329329 }
330330
331331 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r79272-Destroy the DB automatically when initting the DB...soxred9317:30, 30 December 2010

Status & tagging log