r92634 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92633‎ | r92634 | r92635 >
Date:15:13, 20 July 2011
Author:platonides
Status:ok
Tags:
Comment:
Fixup r89029. You don't include the brackets in the method name!

--ta línea y las que están debajo serán ignoradas--

M includes/media/SVGMetadataExtractor.php
M tests/phpunit/includes/media/SVGMetadataExtractorTest.php
Modified paths:
  • /trunk/phase3/includes/media/SVGMetadataExtractor.php (modified) (history)
  • /trunk/phase3/tests/phpunit/includes/media/SVGMetadataExtractorTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/tests/phpunit/includes/media/SVGMetadataExtractorTest.php
@@ -18,7 +18,7 @@
1919 */
2020 function testGetXMLMetadata( $infile, $expected ) {
2121 $r = new XMLReader();
22 - if( !method_exists( $r, 'readInnerXML()' ) ) {
 22+ if( !method_exists( $r, 'readInnerXML' ) ) {
2323 $this->markTestSkipped( 'XMLReader::readInnerXML() does not exist (libxml >2.6.20 needed).' );
2424 return;
2525 }
Index: trunk/phase3/includes/media/SVGMetadataExtractor.php
@@ -177,7 +177,7 @@
178178 return;
179179 }
180180 // TODO: find and store type of xml snippet. metadata['metadataType'] = "rdf"
181 - if( method_exists( $this->reader, 'readInnerXML()' ) ) {
 181+ if( method_exists( $this->reader, 'readInnerXML' ) ) {
182182 $this->metadata[$metafield] = trim( $this->reader->readInnerXML() );
183183 } else {
184184 throw new MWException( "The PHP XMLReader extension does not come with readInnerXML() method. Your libxml is probably out of date (need 2.6.20 or later)." );

Follow-up revisions

RevisionCommit summaryAuthorDate
r93426MFT to REL1_18...hashar20:20, 28 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r89029Handle old libxml when extracting SVG metadata...hashar09:58, 28 May 2011

Status & tagging log