r92630 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r92629‎ | r92630 | r92631 >
Date:12:16, 20 July 2011
Author:j
Status:ok
Tags:media 
Comment:
fix Firefogg upload. use fileChangedOk
Modified paths:
  • /trunk/extensions/UploadWizard/resources/mw.FirefoggHandler.js (modified) (history)
  • /trunk/extensions/UploadWizard/resources/mw.FirefoggTransport.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/resources/mw.FirefoggHandler.js
@@ -88,7 +88,9 @@
8989 .val( _this.getFogg().sourceFilename )
9090 //.trigger('change');
9191 // note the change trigger does not work because we replace the target:
92 - _this.upload.ui.fileChanged();
 92+ var title = _this.getTransport().getFileName().replace( /:/g, '_' );
 93+ _this.upload.title = new mw.Title( title , 'file' );
 94+ _this.upload.ui.fileChangedOk();
9395 }
9496 } );
9597 },
Index: trunk/extensions/UploadWizard/resources/mw.FirefoggTransport.js
@@ -98,7 +98,8 @@
9999 return this.fogg.sourceFilename.split('.').slice(0,-1).join('.') + '.oga';
100100 }
101101 if( this.isSourceVideo() ){
102 - return this.fogg.sourceFilename.split('.').slice(0,-1).join('.') + '.webm';
 102+ var ext = this.getEncodeExt();
 103+ return this.fogg.sourceFilename.split('.').slice(0,-1).join('.') + '.' + ext;
103104 }
104105 }
105106 },

Sign-offs

UserFlagDate
Raindriftinspected23:37, 21 September 2011

Status & tagging log